Performance improvement for the Dart VM runtime method

runtime/vm/raw_object.h

Index: runtime/vm/raw_object.h
===================================================================
--- runtime/vm/raw_object.h	(revision 11476)
+++ runtime/vm/raw_object.h	(working copy)
@@ -1123,10 +1123,18 @@
 };
 
 
+DART_EXTERN_C {
+  Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
+  Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
+  Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);

[turnidge, 2012/08/29 16:53:35]

Does this need to be listed x3?

[Tom Ball, 2012/08/29 17:20:40]

I really, really, really, want it declared? ;-)

It's 1x now, thanks.

+}
+
+
 class RawExternalOneByteString : public RawString {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalOneByteString);
 
   ExternalStringData<uint8_t>* external_data_;
+  friend Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);

[Ivan Posva, 2012/08/29 05:59:30]

Have you tried this?
friend DART_EXTERN_C Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle,
void**);

[Tom Ball, 2012/08/29 17:20:40]

That fails with a syntax error.  According to
http://bytes.com/topic/c/answers/127397-what-proper-syntax-extern-c-friend-vo...,
an explicit extern "C" declaration is required.  Thanks to Todd's review,
though, that declaration is less verbose now.

 };
 
 
@@ -1134,6 +1142,7 @@
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalTwoByteString);
 
   ExternalStringData<uint16_t>* external_data_;
+  friend Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
 };
 
 
@@ -1141,6 +1150,7 @@
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalFourByteString);
 
   ExternalStringData<uint32_t>* external_data_;
+  friend Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
 };