Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: runtime/vm/benchmark_test.cc

Issue 10897014: Performance improvement for the Dart VM runtime method (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/benchmark_test.cc
===================================================================
--- runtime/vm/benchmark_test.cc (revision 11532)
+++ runtime/vm/benchmark_test.cc (working copy)
@@ -200,6 +200,44 @@
//
+// Measure time accessing internal and external strings.
+//
+BENCHMARK(DartStringAccess) {
+ const int kNumIterations = 10000000;
+ Timer timer(true, "DartStringAccess benchmark");
+ timer.Start();
+ Dart_EnterScope();
+
+ // Create strings.
+ uint8_t data8[] = { 'o', 'n', 'e', 0xFF };
+ int external_peer_data = 123;
+ Dart_Handle external_string = Dart_NewExternalString8(data8,
+ ARRAY_SIZE(data8),
+ &external_peer_data,
+ NULL);
+ Dart_Handle internal_string = Dart_NewString("two");
+
+ // Run benchmark.
+ for (int64_t i = 0; i < kNumIterations; i++) {
+ EXPECT(Dart_IsString(internal_string));
+ EXPECT(Dart_IsString8(internal_string));
+ EXPECT(Dart_IsString16(internal_string));
+ EXPECT(!Dart_IsExternalString(internal_string));
+ EXPECT_VALID(external_string);
+ EXPECT(Dart_IsExternalString(external_string));
+ void* external_peer = NULL;
+ EXPECT_VALID(Dart_ExternalStringGetPeer(external_string, &external_peer));
+ EXPECT_EQ(&external_peer_data, external_peer);
+ }
+
+ Dart_ExitScope();
+ timer.Stop();
+ int64_t elapsed_time = timer.TotalElapsedTime();
+ benchmark->set_score(elapsed_time);
+}
+
+
+//
// Measure compile of all dart2js(compiler) functions.
//
static char* ComputeDart2JSPath(const char* arg) {
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698