Performance improvement for the Dart VM runtime method

runtime/vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #include "vm/token.h"
@@ skipping 1105 matching lines @@
     return peer_;
   }
 
  private:
   const T* data_;
   void* peer_;
   Dart_PeerFinalizer callback_;
 };
 
 
+DART_EXTERN_C {
+  Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
+  Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
+  Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
+}
+
+
 class RawExternalOneByteString : public RawString {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalOneByteString);
 
   ExternalStringData<uint8_t>* external_data_;
+  friend Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle o, void**);

[Ivan Posva, 2012/08/28 22:21:20]

Please remove the o to be consistent.
Also can you avoid the above block declaration of the functions being friended?

[Tom Ball, 2012/08/29 00:16:39]

The 'o' is removed, but I think the block declaration is needed, because
otherwise the compiler reports:

error: previous declaration of ‘_Dart_Handle*
dart::Dart_ExternalStringGetPeer(Dart_Handle, void**)’ with ‘C++’ linkage

I tried removing the block and using ::Dart_ExternalStringGetPeer(...) in the
friend statement, since the classes are in the dart namespace but the API
functions aren't, but that failed with:


../runtime/vm/raw_object.h:1129:32: error: ‘dart::ExternalStringData<unsigned
char>* dart::RawExternalOneByteString::external_data_’ is private
../runtime/vm/dart_api_impl.cc:1541:55: error: within this context

Any ideas?

 };
 
 
 class RawExternalTwoByteString : public RawString {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalTwoByteString);
 
   ExternalStringData<uint16_t>* external_data_;
+  friend Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
 };
 
 
 class RawExternalFourByteString : public RawString {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalFourByteString);
 
   ExternalStringData<uint32_t>* external_data_;
+  friend Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle, void**);
 };
 
 
 class RawBool : public RawInstance {
   RAW_HEAP_OBJECT_IMPLEMENTATION(Bool);
 
   bool value_;
 };
 
 
@@ skipping 426 matching lines @@
          kExternalUint64ArrayCid == kByteArrayCid + 18 &&
          kExternalFloat32ArrayCid == kByteArrayCid + 19 &&
          kExternalFloat64ArrayCid == kByteArrayCid + 20 &&
          kStacktraceCid == kByteArrayCid + 21);
   return (index >= kByteArrayCid && index <= kExternalFloat64ArrayCid);
 }
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_