Performance improvement for the Dart VM runtime method

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 1510 matching lines @@
 }
 
 
 DART_EXPORT bool Dart_IsExternalString(Dart_Handle object) {
   return RawObject::IsExternalStringClassId(Api::ClassId(object));
 }
 
 
 DART_EXPORT Dart_Handle Dart_ExternalStringGetPeer(Dart_Handle object,
                                                    void** peer) {
-  Isolate* isolate = Isolate::Current();
-  DARTSCOPE(isolate);
-  const String& str = Api::UnwrapStringHandle(isolate, object);
-  if (str.IsNull()) {
-    RETURN_TYPE_ERROR(isolate, object, String);
-  }
-  if (!str.IsExternal()) {
-    return
-        Api::NewError("%s expects argument 'object' to be an external String.",
-                      CURRENT_FUNC);
-  }
   if (peer == NULL) {
     RETURN_NULL_ERROR(peer);
   }
-  *peer = str.GetPeer();
-  return Api::Success(isolate);
+//  NoGCScope no_gc_scope;
+  if (Dart_IsExternalString(object)) {

[Ivan Posva, 2012/08/28 22:21:20]

I would restructure this a bit to avoid duplicate work and to avoid having part
of the regularly expected work be in the default clause.

NoGCScope no_gc_scope;
intptr_t class_id = Api::ClassId(object);
RawObject* raw_obj = Api::UnwrapHandle(object);
switch (class_id) {
  case kExternalOneByteString:
    ...
    *peer = ...
    break;
  case kExternalTwoByteString:
    ...
    break;
  case kExternalFourByteString:
    ...
    break;
  default: {
    // Error handling is needed.
    if (!RawObject::IsStringClassId(class_id)) {
      RETURN_TYPE_ERROR(...);
    } else {
      ...
    }
}
return Api::Success(Isolate::Current());

[Tom Ball, 2012/08/29 00:16:39]

Thanks, this looks much cleaner -- done.

+    Isolate* isolate = Isolate::Current();
+    intptr_t class_id = Api::ClassId(object);
+    void* raw_peer;
+    switch (class_id) {
+      case kExternalOneByteStringCid: {
+        RawExternalOneByteString* raw_string =
+            (*(reinterpret_cast<RawExternalOneByteString**>(object)))->ptr();

[Ivan Posva, 2012/08/28 22:21:20]

Please do not reach into the internals of handles. There is a convenience method
for this: Api::UnwrapHandle
By doing this we can change the internal implementation or run extra
verification in debug builds.

[Tom Ball, 2012/08/29 00:16:39]

Done.

+        ExternalStringData<uint8_t>* data = raw_string->external_data_;
+        raw_peer = data != NULL ? data->peer() : NULL;

[Ivan Posva, 2012/08/28 22:21:20]

This extra check for data being NULL is not necessary.

[Tom Ball, 2012/08/29 00:16:39]

Done.

+        break;
+      }
+      case kExternalTwoByteStringCid: {
+        RawExternalTwoByteString* raw_string =
+            (*(reinterpret_cast<RawExternalTwoByteString**>(object)))->ptr();
+        ExternalStringData<uint16_t>* data = raw_string->external_data_;
+        raw_peer = data != NULL ? data->peer() : NULL;
+        break;
+      }
+      default: {
+        RawExternalFourByteString* raw_string =
+            (*(reinterpret_cast<RawExternalFourByteString**>(object)))->ptr();
+        ExternalStringData<uint32_t>* data = raw_string->external_data_;
+        raw_peer = data != NULL ? data->peer() : NULL;
+        break;
+      }
+    }
+    if (raw_peer != NULL) {
+      *peer = raw_peer;
+      return Api::Success(isolate);
+    } else {
+      RETURN_TYPE_ERROR(isolate, object, String);
+    }
+  }
+  const char* error_msg = Dart_IsString(object) ?
+      "%s expects argument 'object' to be an external String." :
+      "%s expects argument 'object' to be of type String.";
+  return Api::NewError(error_msg, CURRENT_FUNC);
 }
 
 
 DART_EXPORT Dart_Handle Dart_NewExternalString8(const uint8_t* codepoints,
                                                 intptr_t length,
                                                 void* peer,
                                                 Dart_PeerFinalizer callback) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   if (codepoints == NULL && length != 0) {
@@ skipping 2574 matching lines @@
 DART_EXPORT void Dart_InitPerfEventsSupport(Dart_FileWriterFunction function) {
   Dart::set_perf_events_writer(function);
 }
 
 
 DART_EXPORT void Dart_InitFlowGraphPrinting(Dart_FileWriterFunction function) {
   Dart::set_flow_graph_writer(function);
 }
 
 }  // namespace dart