Introduce some predicates over variable modes.

src/v8globals.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 461 matching lines @@
 const uint32_t kHoleNanUpper32 = 0x7FFFFFFF;
 const uint32_t kHoleNanLower32 = 0xFFFFFFFF;
 const uint32_t kNaNOrInfinityLowerBoundUpper32 = 0x7FF00000;
 
 const uint64_t kHoleNanInt64 =
     (static_cast<uint64_t>(kHoleNanUpper32) << 32) | kHoleNanLower32;
 const uint64_t kLastNonNaNInt64 =
     (static_cast<uint64_t>(kNaNOrInfinityLowerBoundUpper32) << 32);
 
 
 enum VariableMode {

[Sven Panne, 2012/08/29 06:24:24]

Add a warning comment here that the order of the enums matters.

[rossberg, 2012/08/29 09:23:19]

Done.

   // User declared variables:
   VAR,             // declared via 'var', and 'function' declarations
 
   CONST,           // declared via 'const' declarations
 
+  LET,             // declared via 'let' declarations
+
   CONST_HARMONY,   // declared via 'const' declarations in harmony mode
 
-  LET,             // declared via 'let' declarations
-
   // Variables introduced by the compiler:
   DYNAMIC,         // always require dynamic lookup (we don't know
                    // the declaration)
 
   DYNAMIC_GLOBAL,  // requires dynamic lookup, but we know that the
                    // variable is global unless it has been shadowed
                    // by an eval-introduced variable
 
   DYNAMIC_LOCAL,   // requires dynamic lookup, but we know that the
                    // variable is local and where it is unless it
                    // has been shadowed by an eval-introduced
                    // variable
 
   INTERNAL,        // like VAR, but not user-visible (may or may not
                    // be in a context)
 
   TEMPORARY        // temporary variables (not user-visible), never
                    // in a context
 };
 
 
+inline bool IsDynamicVariableMode(VariableMode mode) {
+  return mode >= DYNAMIC && mode <= DYNAMIC_LOCAL;
+}
+
+
+inline bool IsDeclaredVariableMode(VariableMode mode) {
+  return mode >= VAR && mode <= CONST_HARMONY;
+}
+
+
+inline bool IsLexicalVariableMode(VariableMode mode) {
+  return mode >= LET && mode <= CONST_HARMONY;
+}
+
+
+inline bool IsImmutableVariableMode(VariableMode mode) {
+  return mode == CONST || mode == CONST_HARMONY;
+}
+
+
 // ES6 Draft Rev3 10.2 specifies declarative environment records with mutable
 // and immutable bindings that can be in two states: initialized and
 // uninitialized. In ES5 only immutable bindings have these two states. When
 // accessing a binding, it needs to be checked for initialization. However in
 // the following cases the binding is initialized immediately after creation
 // so the initialization check can always be skipped:
 // 1. Var declared local variables.
 //      var foo;
 // 2. A local variable introduced by a function declaration.
 //      function foo() {}
@@ skipping 26 matching lines @@
 
 enum ClearExceptionFlag {
   KEEP_EXCEPTION,
   CLEAR_EXCEPTION
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_V8GLOBALS_H_