Introduce some predicates over variable modes.

Introduce some predicates over variable modes.
These should be handy when we add more declaration forms for Harmony.


R=svenpanne@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=12404

[Sven Panne, 2012-08-29 06:24:24]

LGTM with a nit and a remark: In general, I like this CL, the call sites of the
predicates are much clearer now. Nevertheless, I don't like enums with global
functions working on them, this is basically FORTRAN in 2012. ;-) Making
VariableMode a real class and move the global functions into it is much cleaner
IMHO, groups things together which belong together, and doesn't involve any
runtime cost. But of course I know that this low-level style was not introduced
by this CL... :-P

http://codereview.chromium.org/10897010/diff/1/src/v8globals.h
File src/v8globals.h (right):

http://codereview.chromium.org/10897010/diff/1/src/v8globals.h#newcode482
src/v8globals.h:482: enum VariableMode {
Add a warning comment here that the order of the enums matters.

[rossberg, 2012-08-29 09:23:19]

We use the enum in a switch in a number of places, which cannot be reconciled
with abstraction into a class in C++. So that would be too much hassle.

Generally, I think enums are the right abstraction here. It's just that the
language treats them as the unwanted step child that makes them kind of ugly.

https://chromiumcodereview.appspot.com/10897010/diff/1/src/v8globals.h
File src/v8globals.h (right):

https://chromiumcodereview.appspot.com/10897010/diff/1/src/v8globals.h#newcod...
src/v8globals.h:482: enum VariableMode {
On 2012/08/29 06:24:24, Sven Panne wrote:
> Add a warning comment here that the order of the enums matters.

Done.