Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 10897002: Move webkit/forms/ build into a new webkit_forms.gypi (Closed)

Created:
8 years, 3 months ago by stuartmorgan
Modified:
8 years, 3 months ago
Reviewers:
tony, jam, Ilya Sherman
CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, darin-cc_chromium.org, dyu1
Visibility:
Public.

Description

Move webkit/forms/ build into a new webkit_forms.gypi Most webkit/* directories have their own .gypi file with a static library building that directories files. This does the same for webkit/forms instead of the sources being inlined into the glue target. In addition to be being more like the other directories, this makes it easy for a build to use a subset of webkit/, which is important for iOS. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155405

Patch Set 1 #

Patch Set 2 : Make webkit_forms a component #

Patch Set 3 : Add dependencies on forms target (and rename frow webkit_forms) #

Patch Set 4 : Add missing dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A + webkit/forms/webkit_forms.gypi View 1 2 3 1 chunk +16 lines, -6 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 3 chunks +1 line, -14 lines 0 comments Download
M webkit/support/webkit_support.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
stuartmorgan
8 years, 3 months ago (2012-08-28 08:54:38 UTC) #1
tony
LGTM
8 years, 3 months ago (2012-08-28 18:32:02 UTC) #2
Ilya Sherman
LGTM
8 years, 3 months ago (2012-08-28 18:59:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10897002/1
8 years, 3 months ago (2012-08-28 20:59:55 UTC) #4
commit-bot: I haz the power
Try job failure for 10897002-1 (retry) on mac for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-08-28 21:39:16 UTC) #5
stuartmorgan
Okay, now I know a lot more about the components build :P PTAL I've changed ...
8 years, 3 months ago (2012-08-29 09:49:47 UTC) #6
jam
chrome/content lgtm
8 years, 3 months ago (2012-08-29 15:13:14 UTC) #7
tony
LGTM
8 years, 3 months ago (2012-08-29 16:35:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10897002/9002
8 years, 3 months ago (2012-08-29 17:02:53 UTC) #9
commit-bot: I haz the power
Try job failure for 10897002-9002 (retry) on mac for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-08-29 17:18:50 UTC) #10
stuartmorgan
Sigh, I thought once linux's shared build was happy (it's the fastest try bot with ...
8 years, 3 months ago (2012-08-29 20:24:05 UTC) #11
stuartmorgan
Missing dependencies added; they were straightforward. I'm going to go ahead and land this despite ...
8 years, 3 months ago (2012-09-07 12:07:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10897002/20001
8 years, 3 months ago (2012-09-07 12:07:37 UTC) #13
commit-bot: I haz the power
Try job failure for 10897002-20001 (retry) (retry) on mac_rel for step "sync_integration_tests". It's a second ...
8 years, 3 months ago (2012-09-07 14:23:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10897002/20001
8 years, 3 months ago (2012-09-07 15:08:00 UTC) #15
commit-bot: I haz the power
8 years, 3 months ago (2012-09-07 17:07:11 UTC) #16
Change committed as 155405

Powered by Google App Engine
This is Rietveld 408576698