Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: utils/tests/pub/pub_install_test.dart

Issue 10896051: Improve the error message for pub install without a name key in the pubspec. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/entrypoint.dart ('k') | utils/tests/pub/pub_update_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library('pub_tests'); 5 #library('pub_tests');
6 6
7 #import('dart:io'); 7 #import('dart:io');
8 8
9 #import('test_pub.dart'); 9 #import('test_pub.dart');
10 #import('../../../pkg/unittest/unittest.dart'); 10 #import('../../../pkg/unittest/unittest.dart');
11 11
12 main() { 12 main() {
13 group('requires', () { 13 group('requires', () {
14 test('a pubspec', () { 14 test('a pubspec', () {
15 dir(appPath, []).scheduleCreate(); 15 dir(appPath, []).scheduleCreate();
16 16
17 schedulePub(args: ['install'], 17 schedulePub(args: ['install'],
18 error: const RegExp(@'^Could not find a file named "pubspec.yaml"')); 18 error: const RegExp(@'^Could not find a file named "pubspec.yaml"'));
19 19
20 run(); 20 run();
21 }); 21 });
22 22
23 test('a pubspec with a "name" key', () { 23 test('a pubspec with a "name" key', () {
24 dir(appPath, [ 24 dir(appPath, [
25 pubspec({"dependencies": {"foo": null}}) 25 pubspec({"dependencies": {"foo": null}})
26 ]).scheduleCreate(); 26 ]).scheduleCreate();
27 27
28 schedulePub(args: ['install'], 28 schedulePub(args: ['install'],
29 error: const RegExp(@'^"pubspec.yaml" must contain a "name" key\.')); 29 error: const RegExp(@'^"pubspec.yaml" is missing the required "name" '
30 @'field \(e\.g\. "name: myapp"\)\.'));
30 31
31 run(); 32 run();
32 }); 33 });
33 }); 34 });
34 35
35 test('creates a self-referential symlink', () { 36 test('creates a self-referential symlink', () {
36 // The symlink should use the name in the pubspec, not the name of the 37 // The symlink should use the name in the pubspec, not the name of the
37 // directory. 38 // directory.
38 dir(appPath, [ 39 dir(appPath, [
39 pubspec({"name": "myapp_name"}) 40 pubspec({"name": "myapp_name"})
40 ]).scheduleCreate(); 41 ]).scheduleCreate();
41 42
42 schedulePub(args: ['install'], 43 schedulePub(args: ['install'],
43 output: const RegExp(@"Dependencies installed!$")); 44 output: const RegExp(@"Dependencies installed!$"));
44 45
45 dir(packagesPath, [ 46 dir(packagesPath, [
46 dir("myapp_name", [pubspec({"name": "myapp_name"})]) 47 dir("myapp_name", [pubspec({"name": "myapp_name"})])
47 ]).scheduleValidate(); 48 ]).scheduleValidate();
48 49
49 run(); 50 run();
50 }); 51 });
51 } 52 }
OLDNEW
« no previous file with comments | « utils/pub/entrypoint.dart ('k') | utils/tests/pub/pub_update_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698