Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8224)

Unified Diff: chrome/renderer/resources/extensions/app_window_custom_bindings.js

Issue 10896032: HTML titlebars for v2 apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: kludge test fix for mac Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/renderer_resources.grd ('k') | chrome/renderer/resources/extensions/inject_app_titlebar.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/app_window_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/app_window_custom_bindings.js b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
index fa756783b9647c1b176f2be48e885020989b0017..f8f89115c45d722ac8c09126472d9c61e2089680 100644
--- a/chrome/renderer/resources/extensions/app_window_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
@@ -14,8 +14,10 @@ chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {
var apiFunctions = bindingsAPI.apiFunctions;
apiFunctions.setCustomCallback('create', function(name, request, viewId) {
var view = null;
- if (viewId)
- view = GetView(viewId);
+ if (viewId) {
+ var shouldShowFrame = !request.args[1] || request.args[1].frame != 'none';
+ view = GetView(viewId, !!shouldShowFrame);
+ }
if (request.callback) {
request.callback(view.chrome.app.window.current());
delete request.callback;
« no previous file with comments | « chrome/renderer/renderer_resources.grd ('k') | chrome/renderer/resources/extensions/inject_app_titlebar.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698