chrome/renderer/chrome_render_view_observer.cc - Issue 10896032: HTML titlebars for v2 apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_view_observer.cc

Issue 10896032: HTML titlebars for v2 apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: kludge test fix for mac Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_render_view_observer.cc

diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc

index 0522b2892ba61ffbeb4f8d08b71f12cc2d11891e..ec514b4618a26c1d08db60ec447962ff34dd8312 100644

--- a/chrome/renderer/chrome_render_view_observer.cc

+++ b/chrome/renderer/chrome_render_view_observer.cc

@@ -520,6 +520,10 @@ bool ChromeRenderViewObserver::allowWebComponents(const WebDocument& document,

return true;

if (const extensions::Extension* extension = GetExtension(origin)) {

+ // Titlebars in app windows are implmented via Shadow DOM.

+ if (extension->HasAPIPermission(APIPermission::kAppWindow))

+ return true;

// The <browser> tag is implemented via Shadow DOM.

if (extension->HasAPIPermission(APIPermission::kBrowserTag))

return true;