chrome/renderer/resources/extensions/app_window_custom_bindings.js - Issue 10896032: HTML titlebars for v2 apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/app_window_custom_bindings.js

Issue 10896032: HTML titlebars for v2 apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/app_window_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/app_window_custom_bindings.js b/chrome/renderer/resources/extensions/app_window_custom_bindings.js

index ed430be286df5698911eb2394a619b402ff1515a..694529dbbaf951faa7197971c3cec7658ca2e020 100644

--- a/chrome/renderer/resources/extensions/app_window_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/app_window_custom_bindings.js

@@ -14,7 +14,8 @@ chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {

apiFunctions.setCustomCallback('create', function(name, request, viewId) {

var view = null;

if (viewId)

- view = GetView(viewId);

+ // XXX does request.args[1] always exist?

+ view = GetView(viewId, request.args[1].frame != 'none');

if (request.callback) {

request.callback(view);

delete request.callback;