Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Side by Side Diff: chrome/browser/chromeos/contacts/contact_database_unittest.cc

Issue 10896031: contacts: Add ContactManagerInterface::GetWeakPtr(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: apply review feedback Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/contacts/contact_database.h" 5 #include "chrome/browser/chromeos/contacts/contact_database.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 const int64 kNewLastUpdateTime = 5678; 194 const int64 kNewLastUpdateTime = 5678;
195 metadata_to_save->set_last_update_start_time(kNewLastUpdateTime); 195 metadata_to_save->set_last_update_start_time(kNewLastUpdateTime);
196 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true); 196 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true);
197 197
198 LoadContacts(&loaded_contacts, &loaded_metadata); 198 LoadContacts(&loaded_contacts, &loaded_metadata);
199 EXPECT_EQ(VarContactsToString(1, contact.get()), 199 EXPECT_EQ(VarContactsToString(1, contact.get()),
200 ContactsToString(*loaded_contacts)); 200 ContactsToString(*loaded_contacts));
201 EXPECT_EQ(kNewLastUpdateTime, loaded_metadata->last_update_start_time()); 201 EXPECT_EQ(kNewLastUpdateTime, loaded_metadata->last_update_start_time());
202 } 202 }
203 203
204 TEST_F(ContactDatabaseTest, FullAndPartialUpdates) { 204 TEST_F(ContactDatabaseTest, FullAndIncrementalUpdates) {
205 // Do a full update that inserts two contacts into the database. 205 // Do a full update that inserts two contacts into the database.
206 const std::string kContactId1 = "contact_id_1"; 206 const std::string kContactId1 = "contact_id_1";
207 const std::string kSharedEmail = "foo@example.org"; 207 const std::string kSharedEmail = "foo@example.org";
208 scoped_ptr<Contact> contact1(new Contact); 208 scoped_ptr<Contact> contact1(new Contact);
209 InitContact(kContactId1, "1", false, contact1.get()); 209 InitContact(kContactId1, "1", false, contact1.get());
210 AddEmailAddress(kSharedEmail, Contact_AddressType_Relation_HOME, 210 AddEmailAddress(kSharedEmail, Contact_AddressType_Relation_HOME,
211 "", true, contact1.get()); 211 "", true, contact1.get());
212 212
213 const std::string kContactId2 = "contact_id_2"; 213 const std::string kContactId2 = "contact_id_2";
214 scoped_ptr<Contact> contact2(new Contact); 214 scoped_ptr<Contact> contact2(new Contact);
215 InitContact(kContactId2, "2", false, contact2.get()); 215 InitContact(kContactId2, "2", false, contact2.get());
216 AddEmailAddress(kSharedEmail, Contact_AddressType_Relation_WORK, 216 AddEmailAddress(kSharedEmail, Contact_AddressType_Relation_WORK,
217 "", true, contact2.get()); 217 "", true, contact2.get());
218 218
219 scoped_ptr<ContactPointers> contacts_to_save(new ContactPointers); 219 scoped_ptr<ContactPointers> contacts_to_save(new ContactPointers);
220 contacts_to_save->push_back(contact1.get()); 220 contacts_to_save->push_back(contact1.get());
221 contacts_to_save->push_back(contact2.get()); 221 contacts_to_save->push_back(contact2.get());
222 scoped_ptr<UpdateMetadata> metadata_to_save(new UpdateMetadata); 222 scoped_ptr<UpdateMetadata> metadata_to_save(new UpdateMetadata);
223 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true); 223 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), true);
224 224
225 scoped_ptr<ScopedVector<Contact> > loaded_contacts; 225 scoped_ptr<ScopedVector<Contact> > loaded_contacts;
226 scoped_ptr<UpdateMetadata> loaded_metadata; 226 scoped_ptr<UpdateMetadata> loaded_metadata;
227 LoadContacts(&loaded_contacts, &loaded_metadata); 227 LoadContacts(&loaded_contacts, &loaded_metadata);
228 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()), 228 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()),
229 ContactsToString(*loaded_contacts)); 229 ContactsToString(*loaded_contacts));
230 230
231 // Do a partial update including just the second contact. 231 // Do an incremental update including just the second contact.
232 InitContact(kContactId2, "2b", false, contact2.get()); 232 InitContact(kContactId2, "2b", false, contact2.get());
233 AddPostalAddress("postal_1", Contact_AddressType_Relation_HOME, 233 AddPostalAddress("postal_1", Contact_AddressType_Relation_HOME,
234 "", true, contact2.get()); 234 "", true, contact2.get());
235 contacts_to_save.reset(new ContactPointers); 235 contacts_to_save.reset(new ContactPointers);
236 contacts_to_save->push_back(contact2.get()); 236 contacts_to_save->push_back(contact2.get());
237 metadata_to_save.reset(new UpdateMetadata); 237 metadata_to_save.reset(new UpdateMetadata);
238 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), false); 238 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), false);
239 LoadContacts(&loaded_contacts, &loaded_metadata); 239 LoadContacts(&loaded_contacts, &loaded_metadata);
240 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()), 240 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()),
241 ContactsToString(*loaded_contacts)); 241 ContactsToString(*loaded_contacts));
242 242
243 // Do an empty partial update and check that the metadata is still updated. 243 // Do an empty incremental update and check that the metadata is still
244 // updated.
244 contacts_to_save.reset(new ContactPointers); 245 contacts_to_save.reset(new ContactPointers);
245 metadata_to_save.reset(new UpdateMetadata); 246 metadata_to_save.reset(new UpdateMetadata);
246 const int64 kLastUpdateTime = 1234; 247 const int64 kLastUpdateTime = 1234;
247 metadata_to_save->set_last_update_start_time(kLastUpdateTime); 248 metadata_to_save->set_last_update_start_time(kLastUpdateTime);
248 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), false); 249 SaveContacts(contacts_to_save.Pass(), metadata_to_save.Pass(), false);
249 LoadContacts(&loaded_contacts, &loaded_metadata); 250 LoadContacts(&loaded_contacts, &loaded_metadata);
250 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()), 251 EXPECT_EQ(VarContactsToString(2, contact1.get(), contact2.get()),
251 ContactsToString(*loaded_contacts)); 252 ContactsToString(*loaded_contacts));
252 EXPECT_EQ(kLastUpdateTime, loaded_metadata->last_update_start_time()); 253 EXPECT_EQ(kLastUpdateTime, loaded_metadata->last_update_start_time());
253 254
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 297
297 scoped_ptr<ScopedVector<Contact> > loaded_contacts; 298 scoped_ptr<ScopedVector<Contact> > loaded_contacts;
298 scoped_ptr<UpdateMetadata> loaded_metadata; 299 scoped_ptr<UpdateMetadata> loaded_metadata;
299 LoadContacts(&loaded_contacts, &loaded_metadata); 300 LoadContacts(&loaded_contacts, &loaded_metadata);
300 EXPECT_EQ(VarContactsToString(1, contact.get()), 301 EXPECT_EQ(VarContactsToString(1, contact.get()),
301 ContactsToString(*loaded_contacts)); 302 ContactsToString(*loaded_contacts));
302 } 303 }
303 304
304 } // namespace test 305 } // namespace test
305 } // namespace contacts 306 } // namespace contacts
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/contacts/contact_database.cc ('k') | chrome/browser/chromeos/contacts/contact_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698