Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 10896030: Change some IndexedDBCallbacks<> specializations to derived classes (Closed)

Created:
8 years, 3 months ago by dgrogan
Modified:
8 years, 3 months ago
Reviewers:
jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, alecflett
Visibility:
Public.

Description

Change some IndexedDBCallbacks<> specializations to derived classes Specifically, removes IndexedDBCallbacks<WebIDB{Transaction, Database}> in favor of IndexedDBCallbacks{Transaction, Database}. Also runs some integer version layout tests as browser tests. This would have exposed bug 143680 earlier. BUG=143680 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154111

Patch Set 1 #

Patch Set 2 : Move some stuff from .h to .cc #

Patch Set 3 : Add TODO to convert the rest of the specializations #

Total comments: 9

Patch Set 4 : fix nits #

Patch Set 5 : sync to ToT #

Patch Set 6 : sync to ToT 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -55 lines) Patch
M content/browser/in_process_webkit/indexed_db_callbacks.h View 1 2 3 chunks +29 lines, -50 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_callbacks.cc View 1 2 3 2 chunks +47 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_layout_browsertest.cc View 1 2 3 4 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
dgrogan
Josh, could you review this? Patchset 1 has green try runs.
8 years, 3 months ago (2012-08-29 03:57:58 UTC) #1
jsbell
lgtm with nits. (win compile failure looks unrelated?) http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_webkit/indexed_db_callbacks.cc File content/browser/in_process_webkit/indexed_db_callbacks.cc (right): http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_webkit/indexed_db_callbacks.cc#newcode15 content/browser/in_process_webkit/indexed_db_callbacks.cc:15: int32 ...
8 years, 3 months ago (2012-08-29 15:50:07 UTC) #2
dgrogan
http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_webkit/indexed_db_callbacks.cc File content/browser/in_process_webkit/indexed_db_callbacks.cc (right): http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_webkit/indexed_db_callbacks.cc#newcode15 content/browser/in_process_webkit/indexed_db_callbacks.cc:15: int32 kDatabaseNotAdded = -1; On 2012/08/29 15:50:07, jsbell wrote: ...
8 years, 3 months ago (2012-08-29 18:43:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/7006
8 years, 3 months ago (2012-08-29 18:43:38 UTC) #4
commit-bot: I haz the power
Try job failure for 10896030-7006 (retry) (retry) on win_rel for step "browser_tests" (clobber build). It's ...
8 years, 3 months ago (2012-08-29 23:05:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/7006
8 years, 3 months ago (2012-08-29 23:08:02 UTC) #6
commit-bot: I haz the power
Try job failure for 10896030-7006 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 3 months ago (2012-08-30 02:17:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/7006
8 years, 3 months ago (2012-08-30 02:34:24 UTC) #8
commit-bot: I haz the power
Try job failure for 10896030-7006 (retry) on win for step "runhooks" (clobber build). It's a ...
8 years, 3 months ago (2012-08-30 03:22:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/2006
8 years, 3 months ago (2012-08-30 03:35:27 UTC) #10
commit-bot: I haz the power
Try job failure for 10896030-2006 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-08-30 05:18:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/2006
8 years, 3 months ago (2012-08-30 05:47:25 UTC) #12
commit-bot: I haz the power
Try job failure for 10896030-2006 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-08-30 07:45:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/2006
8 years, 3 months ago (2012-08-30 08:03:56 UTC) #14
commit-bot: I haz the power
8 years, 3 months ago (2012-08-30 10:00:20 UTC) #15
Try job failure for 10896030-2006 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698