Change some IndexedDBCallbacks<> specializations to derived classes

Change some IndexedDBCallbacks<> specializations to derived classes

Specifically, removes IndexedDBCallbacks<WebIDB{Transaction, Database}> in
favor of IndexedDBCallbacks{Transaction, Database}.

Also runs some integer version layout tests as browser tests. This would have 
exposed bug 143680 earlier.

BUG=143680
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154111

[dgrogan, 2012-08-29 03:57:58]

Josh, could you review this?  Patchset 1 has green try runs.

[jsbell, 2012-08-29 15:50:07]

lgtm with nits.

(win compile failure looks unrelated?)

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
File content/browser/in_process_webkit/indexed_db_callbacks.cc (right):

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_callbacks.cc:15: int32
kDatabaseNotAdded = -1;
const?

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_callbacks.cc:50:
origin_url_(origin_url) {
Indenting.

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_callbacks.cc:68:
origin_url_(origin_url),
Indenting.

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_callbacks.cc:69:
database_id_(kDatabaseNotAdded) {
Ditto.

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
File content/browser/in_process_webkit/indexed_db_layout_browsertest.cc (right):

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_layout_browsertest.cc:103: // 
"intversion-gated-on-delete.html", // behaves slightly differently in DRT
Yeah, would love to strategize about that. The deleteDatabase IPC message is
async which means it can fall on either side of other async operations like the
version setting task which fires off the onupgradeneeded.

Agreed to skip the test for now.

[dgrogan, 2012-08-29 18:43:23]

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
File content/browser/in_process_webkit/indexed_db_callbacks.cc (right):

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_callbacks.cc:15: int32
kDatabaseNotAdded = -1;
On 2012/08/29 15:50:07, jsbell wrote:
> const?

Done.

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_callbacks.cc:50:
origin_url_(origin_url) {
On 2012/08/29 15:50:07, jsbell wrote:
> Indenting.

Done.

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_callbacks.cc:68:
origin_url_(origin_url),
On 2012/08/29 15:50:07, jsbell wrote:
> Indenting.

Done.

http://codereview.chromium.org/10896030/diff/7/content/browser/in_process_web...
content/browser/in_process_webkit/indexed_db_callbacks.cc:69:
database_id_(kDatabaseNotAdded) {
On 2012/08/29 15:50:07, jsbell wrote:
> Ditto.

Done.

[commit-bot: I haz the power, 2012-08-29 18:43:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/7006

[commit-bot: I haz the power, 2012-08-29 23:05:48]

Try job failure for 10896030-7006 (retry) (retry) on win_rel for step
"browser_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-29 23:08:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/7006

[commit-bot: I haz the power, 2012-08-30 02:17:56]

Try job failure for 10896030-7006 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-30 02:34:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/7006

[commit-bot: I haz the power, 2012-08-30 03:22:24]

Try job failure for 10896030-7006 (retry) on win for step "runhooks" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-30 03:35:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/2006

[commit-bot: I haz the power, 2012-08-30 05:18:56]

Try job failure for 10896030-2006 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-30 05:47:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/2006

[commit-bot: I haz the power, 2012-08-30 07:45:01]

Try job failure for 10896030-2006 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-30 08:03:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10896030/2006

[commit-bot: I haz the power, 2012-08-30 10:00:20]

Try job failure for 10896030-2006 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...