Add a bool return value to media::Decryptor::GenerateKeyRequest().

Add a bool return value to media::Decryptor::GenerateKeyRequest().

Add a bool return value in media::Decryptor::GenerateKeyRequest() call and add code in WebMeidaPlayerImpl to check this value. If GenerateKeyRequest() fails, prevent further calls to AddKey() and CancelKeyRequest().

BUG=145322
TEST=Called AddKey() after GenerateKeyRequest() fails and no crash.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153818

[xhwang, 2012-08-28 21:41:46]

Hello ddorwin,

This is the fix to the bug you found :) PTAL!

xhwang

[ddorwin, 2012-08-28 21:59:14]

LG except one corner case.

http://codereview.chromium.org/10896014/diff/2001/webkit/media/crypto/proxy_d...
File webkit/media/crypto/proxy_decryptor.cc (right):

http://codereview.chromium.org/10896014/diff/2001/webkit/media/crypto/proxy_d...
webkit/media/crypto/proxy_decryptor.cc:91: return
decryptor_->GenerateKeyRequest(key_system,
For the meaning of the return value to be consistent (CDM is not established), I
think we need to destroy decryptor_ if this call fails. Otherwise, you could end
up with a plugin for one KS that can't be changed to another one with a future
GKR call.

[ddorwin, 2012-08-28 22:35:24]

lgtm

[commit-bot: I haz the power, 2012-08-28 22:45:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/10896014/3012

[commit-bot: I haz the power, 2012-08-29 01:14:41]

Change committed as 153818