Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10894050: Remove support for Windows-style keycodes. (Closed)

Created:
8 years, 3 months ago by Wez
Modified:
8 years, 3 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Remove support for Windows-style keycodes. BUG=145057 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155905

Patch Set 1 #

Patch Set 2 : DCHECK in EventExecutors if the USB keycode is missing #

Total comments: 2

Patch Set 3 : Fix Linux EventExecutor typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -559 lines) Patch
M remoting/client/key_event_mapper_unittest.cc View 4 chunks +5 lines, -29 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_input_handler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 2 5 chunks +15 lines, -14 lines 0 comments Download
M remoting/host/event_executor_linux.cc View 1 2 4 chunks +5 lines, -183 lines 0 comments Download
M remoting/host/event_executor_mac.cc View 1 2 2 chunks +5 lines, -195 lines 0 comments Download
M remoting/host/event_executor_win.cc View 1 2 chunks +9 lines, -46 lines 0 comments Download
M remoting/host/remote_input_filter_unittest.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M remoting/proto/event.proto View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/client_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/host_event_dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/input_event_tracker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/input_event_tracker.cc View 3 chunks +1 line, -16 lines 0 comments Download
M remoting/protocol/input_event_tracker_unittest.cc View 9 chunks +10 lines, -53 lines 0 comments Download
M remoting/protocol/message_decoder_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Wez
PTAL
8 years, 3 months ago (2012-08-30 00:50:50 UTC) #1
Wez
On 2012/08/30 00:50:50, Wez wrote: > PTAL Ping! :)
8 years, 3 months ago (2012-08-31 23:07:25 UTC) #2
Wez
On 2012/08/31 23:07:25, Wez wrote: > On 2012/08/30 00:50:50, Wez wrote: > > PTAL > ...
8 years, 3 months ago (2012-09-06 00:42:51 UTC) #3
garykac
lgtm http://codereview.chromium.org/10894050/diff/2001/remoting/proto/event.proto File remoting/proto/event.proto (right): http://codereview.chromium.org/10894050/diff/2001/remoting/proto/event.proto#newcode16 remoting/proto/event.proto:16: //optional int32 keycode = 1; Remove this and ...
8 years, 3 months ago (2012-09-06 00:58:27 UTC) #4
Wez
http://codereview.chromium.org/10894050/diff/2001/remoting/proto/event.proto File remoting/proto/event.proto (right): http://codereview.chromium.org/10894050/diff/2001/remoting/proto/event.proto#newcode16 remoting/proto/event.proto:16: //optional int32 keycode = 1; On 2012/09/06 00:58:27, garykac ...
8 years, 3 months ago (2012-09-07 00:29:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10894050/2001
8 years, 3 months ago (2012-09-07 00:38:58 UTC) #6
commit-bot: I haz the power
Try job failure for 10894050-2001 (retry) (previous was lost) on linux_clang for step "compile" (clobber ...
8 years, 3 months ago (2012-09-07 01:24:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10894050/14001
8 years, 3 months ago (2012-09-07 05:28:56 UTC) #8
commit-bot: I haz the power
Try job failure for 10894050-14001 (retry) on mac_rel for step "sync_integration_tests". It's a second try, ...
8 years, 3 months ago (2012-09-07 07:29:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10894050/14001
8 years, 3 months ago (2012-09-07 17:07:26 UTC) #10
commit-bot: I haz the power
Try job failure for 10894050-14001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-09-07 19:07:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10894050/14001
8 years, 3 months ago (2012-09-10 22:45:36 UTC) #12
commit-bot: I haz the power
8 years, 3 months ago (2012-09-11 01:52:17 UTC) #13 
Change committed as 155905

Powered by Google App Engine
This is Rietveld 408576698