ChromeOS: Implement MediaTransferProtocolManager observer.

chrome/browser/chromeos/mtp/media_transfer_protocol_device_observer_unittest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// MediaTransferProtocolDeviceObserver unit tests.
+
+#include "chrome/browser/chromeos/mtp/media_transfer_protocol_device_observer.h"
+
+#include <string>
+
+#include "base/message_loop.h"
+#include "base/memory/scoped_ptr.h"

[Lei Zhang, 2012/08/30 02:30:20]

nit: alphabetical order

[kmadhusu, 2012/08/30 03:12:58]

oops.. Fixed.

+#include "base/system_monitor/system_monitor.h"
+#include "base/test/mock_devices_changed_observer.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/media_gallery/media_storage_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chromeos {
+namespace mtp {
+
+namespace {
+
+// Sample mtp device storage information.
+const char kStorageLabel[] = "Camera V1.0";
+const char kStorageLocation[] = "/usb:2,2,88888";
+const char kStorageName[] = "usb:2,2,88888";
+const char kStorageUniqueId[] = "VendorModelSerial:COM:MOD2012:283";
+
+// Returns the mtp device id given the |unique_id|.
+std::string GetMtpDeviceId(const std::string& unique_id) {
+  return chrome::MediaStorageUtil::MakeDeviceId(
+      chrome::MediaStorageUtil::MTP_OR_PTP, unique_id);
+}
+
+// Helper function to get the device storage details such as device id, label
+// and location. On success, fills in |id|, |label| and |location|.
+void GetStorageInfo(const std::string& storage_name,
+                    std::string* id,
+                    string16* label,
+                    std::string* location) {
+  if (storage_name != kStorageName) {
+    NOTREACHED();
+    return;
+  }
+  if (id)
+    *id = GetMtpDeviceId(kStorageUniqueId);
+  if (label)
+    *label = ASCIIToUTF16(kStorageLabel);
+  if (location)
+    *location = kStorageLocation;
+}
+
+}  // namespace

[Lei Zhang, 2012/08/30 02:30:20]

You can put the entire test in the anonymous namespace too. There's no reason
for it to be outside.

[kmadhusu, 2012/08/30 03:12:58]

Done.

+
+class MediaTransferProtocolDeviceObserverTest : public testing::Test {
+ public:
+  MediaTransferProtocolDeviceObserverTest() {}
+  virtual ~MediaTransferProtocolDeviceObserverTest() {}
+
+ protected:
+  virtual void SetUp() OVERRIDE {
+    mock_devices_changed_observer_.reset(new base::MockDevicesChangedObserver);
+    system_monitor_.AddDevicesChangedObserver(
+        mock_devices_changed_observer_.get());
+
+    // Initialize the test subject.
+    mtp_dev_observer_.reset(
+        new MediaTransferProtocolDeviceObserver(&GetStorageInfo));
+  }
+
+  virtual void TearDown() OVERRIDE {
+    mtp_dev_observer_.reset();
+    system_monitor_.RemoveDevicesChangedObserver(
+        mock_devices_changed_observer_.get());
+  }
+
+  // Returns the device changed observer object.
+  base::MockDevicesChangedObserver& observer() {
+    return *mock_devices_changed_observer_;
+  }
+
+  // Notifies |MediaTransferProtocolDeviceObserver| about the attachment of
+  // mtp storage device given the |storage_name|.
+  void MtpStorageAttached(const std::string& storage_name) {
+    mtp_dev_observer_->StorageChanged(true, storage_name);
+    ui_loop_.RunAllPending();
+  }
+
+  // Notifies |MediaTransferProtocolDeviceObserver| about the detachment of
+  // mtp storage device given the |storage_name|.
+  void MtpStorageDetached(const std::string& storage_name) {
+    mtp_dev_observer_->StorageChanged(false, storage_name);
+    ui_loop_.RunAllPending();
+  }
+
+ private:
+  // Message loop to run the test on.
+  MessageLoop ui_loop_;
+
+  // SystemMonitor and DevicesChangedObserver to hook together to test.
+  base::SystemMonitor system_monitor_;
+  scoped_ptr<base::MockDevicesChangedObserver> mock_devices_changed_observer_;
+
+  // Test subject.
+  scoped_ptr<MediaTransferProtocolDeviceObserver> mtp_dev_observer_;
+
+  DISALLOW_COPY_AND_ASSIGN(MediaTransferProtocolDeviceObserverTest);
+};
+
+// Test to verify basic mtp storage attach and detach notifications.
+TEST_F(MediaTransferProtocolDeviceObserverTest, BasicAttachDetach) {
+  testing::Sequence mock_sequence;
+  std::string device_id = GetMtpDeviceId(kStorageUniqueId);
+
+  EXPECT_CALL(observer(),
+              OnRemovableStorageAttached(device_id,
+                                         ASCIIToUTF16(kStorageLabel),
+                                         kStorageLocation))
+      .InSequence(mock_sequence);
+
+  // Attach a mtp storage.

[Lei Zhang, 2012/08/30 02:30:20]

I would put this above the EXPECT_CALL, and get rid of the newline between
EXPECT_CALL and MtpStorageFoo(), so it's clear where the code for a particular
test starts and ends.

[kmadhusu, 2012/08/30 03:12:58]

Done.

+  MtpStorageAttached(kStorageName);
+
+  EXPECT_CALL(observer(), OnRemovableStorageDetached(device_id))
+      .InSequence(mock_sequence);
+
+  // Detach the attached storage.
+  MtpStorageDetached(kStorageName);
+}
+
+}  // namespace mtp
+}  // namespace chromeos