ChromeOS: Implement MediaTransferProtocolManager observer.

chrome/browser/chromeos/mtp/mtp_dev_manager_observer.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_MTP_MTP_DEV_MANAGER_OBSERVER_H_
+#define CHROME_BROWSER_CHROMEOS_MTP_MTP_DEV_MANAGER_OBSERVER_H_
+
+#include <map>
+#include <string>
+
+#include "base/string16.h"

[Lei Zhang, 2012/08/29 23:11:15]

nit: alphabetical order

[kmadhusu, 2012/08/30 02:07:50]

Done.

+#include "base/memory/ref_counted.h"
+#include "chrome/browser/chromeos/mtp/media_transfer_protocol_manager.h"
+
+namespace chromeos {
+namespace mtp {
+
+// Gets the mtp device information given a |storage_name|. On success,
+// fills in |id|, |name| and |location|.
+typedef void (*GetStorageInfoFunc)(const std::string& storage_name,
+                                  std::string* id,

[Lei Zhang, 2012/08/29 23:11:15]

nit: indentation

[kmadhusu, 2012/08/30 02:07:50]

Done.

+                                  string16* name,
+                                  std::string* location);
+
+// Helper class to send MTP storage attachment and detachment events to
+// SystemMonitor.
+class MtpDevManagerObserver

[Lei Zhang, 2012/08/29 23:11:15]

Can you be consistent with the name and call this
MediaTransferProtocolDeviceObserver?

[kmadhusu, 2012/08/30 02:07:50]

Done.

+    : public base::RefCountedThreadSafe<MtpDevManagerObserver>,

[Lei Zhang, 2012/08/29 23:11:15]

Why does this need to be RefCountedThreadSafe?

[kmadhusu, 2012/08/30 02:07:50]

RefCounting is not required here. Fixed.

+      public MediaTransferProtocolManager::Observer {
+ public:
+  MtpDevManagerObserver();
+
+  // Only used in unit tests.
+  explicit MtpDevManagerObserver(GetStorageInfoFunc get_storage_info_func);
+
+  // MediaTransferProtocolManager::Observer implementation.
+  // Exposed for unit tests.
+  virtual void StorageChanged(bool is_attached,
+                              const std::string& storage_name) OVERRIDE;
+
+ private:
+  friend class base::RefCountedThreadSafe<MtpDevManagerObserver>;
+
+  // Mapping of storage name and unique id.
+  typedef std::map<std::string, std::string> StorageNameAndIdMap;
+
+  // Private to avoid code deleting the object.
+  virtual ~MtpDevManagerObserver();
+
+  // Enumerate existing mtp storage devices.
+  void EnumerateStorages();
+
+  // Map of all attached mtp devices.
+  StorageNameAndIdMap storage_map_;
+
+  // Function handler to get storage information. This is useful to set a mock
+  // handler for unit testing.
+  GetStorageInfoFunc get_storage_info_func_;
+
+  DISALLOW_COPY_AND_ASSIGN(MtpDevManagerObserver);
+};
+
+}  // namespace mtp
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_MTP_MTP_DEV_MANAGER_OBSERVER_H_