Fix hunk handling for 'default hunk header values'.

Fix hunk handling for 'default hunk header values'.

Add new test cases to verify it properly handles "-1 +1, 2" and "-1 +1" for
short files.

R=petermayo@chromium.org
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153906

[Peter Mayo, 2012-08-29 16:49:40]

LGTM
With optional observations.

https://chromiumcodereview.appspot.com/10894036/diff/1/patch.py
File patch.py (right):

https://chromiumcodereview.appspot.com/10894036/diff/1/patch.py#newcode139
patch.py:139: return '%s<%d, %d, %d, %d>' % (
Question: are there any punctuation/separators that would make this
representation more self-documenting, like -> or -, +, ...
?

https://chromiumcodereview.appspot.com/10894036/diff/1/patch.py#newcode238
patch.py:238: match = re.match(r'^@@ -([\d,]+) \+([\d,]+) @@.*$', line)
This will match multiple commas, which might be better handled as an exception.

[M-A Ruel, 2012-08-29 17:15:29]

https://chromiumcodereview.appspot.com/10894036/diff/1/patch.py
File patch.py (right):

https://chromiumcodereview.appspot.com/10894036/diff/1/patch.py#newcode139
patch.py:139: return '%s<%d, %d, %d, %d>' % (
On 2012/08/29 16:49:40, Peter Mayo wrote:
> Question: are there any punctuation/separators that would make this
> representation more self-documenting, like -> or -, +, ...
> ?

Used (%d, %d) to (%d, %d) instead, but that's really just for internal
consumption.

https://chromiumcodereview.appspot.com/10894036/diff/1/patch.py#newcode238
patch.py:238: match = re.match(r'^@@ -([\d,]+) \+([\d,]+) @@.*$', line)
On 2012/08/29 16:49:40, Peter Mayo wrote:
> This will match multiple commas, which might be better handled as an
exception.

Added code to verify this. Broken hunks are rather rare, it's really just to
make sure the parsing code is not receiving unexpected data. Anyhow,
double-commas was already throwing an exception, the error message is simply
nicer now.

[commit-bot: I haz the power, 2012-08-29 17:15:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10894036/5001

[commit-bot: I haz the power, 2012-08-29 17:18:16]

Change committed as 153906