runtime/vm/flow_graph_compiler.cc - Issue 10894034: Make constants computations instead of values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 10894034: Make constants computations instead of values. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler.cc

diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc

index 264b623ade62d524a66d1fd3562d0a00c9cc2d39..04d9cdb68080bb4ff453f4138f709109e2a0c45a 100644

--- a/runtime/vm/flow_graph_compiler.cc

+++ b/runtime/vm/flow_graph_compiler.cc

@@ -49,8 +49,7 @@ RawDeoptInfo* DeoptimizationStub::CreateDeoptInfo(FlowGraphCompiler* compiler) {

// Assign locations to values pushed above spill slots with PushArgument.

intptr_t height = compiler->StackSize();

for (intptr_t i = 0; i < values.length(); i++) {

- if (deoptimization_env_->LocationAt(i).IsInvalid() &&

- !values[i]->IsConstant()) {

+ if (deoptimization_env_->LocationAt(i).IsInvalid()) {

ASSERT(values[i]->AsUse()->definition()->IsPushArgument());

*deoptimization_env_->LocationSlotAt(i) = Location::StackSlot(height++);

}