Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 10894031: Update jpeg name mangling to allow linking with both IJG libjpeg and turbo_libjpeg (Closed)

Created:
8 years, 3 months ago by Emmanuel Saint-loubert-Bié
Modified:
8 years, 3 months ago
Reviewers:
tony
CC:
chromium-reviews
Visibility:
Public.

Description

In some situation on CrOS we need to have with both IJG libjpeg and libjpeg_turbo. This CL update the jpeg name mangling to allow linking both. 1) Prefixing with just chromium_ was insufficient because WebKit will pull libjpeg_turbo on most platforms and that has the same demangling rules 2) Two symbols were missing: jpeg_std_message_table jpeg_natural_order 3) Sorted macros in alpha order. BUG=144296 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -104 lines) Patch
M third_party/libjpeg/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libjpeg/jpeglibmangler.h View 2 chunks +104 lines, -102 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Emmanuel Saint-loubert-Bié
Hi Tony, Since you seem to have been touching this library please review. Thanks, -- ...
8 years, 3 months ago (2012-08-29 01:20:34 UTC) #1
tony
I don't understand. Doesn't WebKit and chromium use the same copy of libjpeg_turbo? Are you ...
8 years, 3 months ago (2012-08-29 16:48:13 UTC) #2
Emmanuel Saint-loubert-Bié
Hi Tony, What I am saying is that unless I land this CL we cannot ...
8 years, 3 months ago (2012-08-29 16:50:09 UTC) #3
tony
LGTM Please update the change description to say 'why' we need both. I would make ...
8 years, 3 months ago (2012-08-29 16:58:06 UTC) #4
Emmanuel Saint-loubert-Bié
On 2012/08/29 16:58:06, tony wrote: > LGTM > > Please update the change description to ...
8 years, 3 months ago (2012-08-29 17:04:42 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-08-29 17:05:08 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698