Issue 10894019: Enforce coherent type handling in git_cl.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10894019: Enforce coherent type handling in git_cl.py (Closed)

Created:
8 years, 3 months ago by M-A Ruel

Modified:
8 years, 3 months ago

Reviewers:
cmp, Peter Mayo

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Enforce coherent type handling in git_cl.py Issue and patchset can only be int, so store them as ints. This fixes git cl comment, which was broken by r152756. R=petermayo@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153885

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -21 lines)			Patch
	M	git_cl.py	View		12 chunks	+15 lines, -21 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10894019/1

8 years, 3 months ago (2012-08-29 15:11:13 UTC) #3

lgtm