Remove library_map.dart.

Remove library_map.dart.

Committed: https://code.google.com/p/dart/source/detail?r=11519

[ahe, 2012-08-28 13:18:51]

I'm concerned about dart:compiler.

https://chromiumcodereview.appspot.com/10894005/diff/1/lib/_internal/librarie...
File lib/_internal/libraries.dart (right):

https://chromiumcodereview.appspot.com/10894005/diff/1/lib/_internal/librarie...
lib/_internal/libraries.dart:32: "compiler": const LibraryInfo(
Will dart2js now support a library named dart:compiler?

[Johnni Winther, 2012-08-28 13:26:04]

lgtm

https://chromiumcodereview.appspot.com/10894005/diff/1/lib/compiler/implement...
File lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10894005/diff/1/lib/compiler/implement...
lib/compiler/implementation/apiimpl.dart:39: String dartLibraryPath(String
dartLibraryName) {
Rename to getDartLibraryPath.

https://chromiumcodereview.appspot.com/10894005/diff/1/lib/compiler/implement...
lib/compiler/implementation/apiimpl.dart:48: String dartPatchPath(String
dartLibraryName) {
Rename to getDartPatchPath.

[dgrove, 2012-08-28 15:19:12]

https://chromiumcodereview.appspot.com/10894005/diff/1/lib/_internal/librarie...
File lib/_internal/libraries.dart (right):

https://chromiumcodereview.appspot.com/10894005/diff/1/lib/_internal/librarie...
lib/_internal/libraries.dart:32: "compiler": const LibraryInfo(
On 2012/08/28 13:18:51, ahe wrote:
> Will dart2js now support a library named dart:compiler?
I sure hope not. I would suggest that we not include compiler in this file.

[ahe, 2012-08-28 15:32:18]

Lasse, to be clear: please don't submit this change until we get to the bottom
of dart:compiler.

[danrubel, 2012-08-28 16:31:59]

On 2012/08/28 15:32:18, ahe wrote:
> Lasse, to be clear: please don't submit this change until we get to the bottom
> of dart:compiler.

dart:compiler was copied over from our internal dart: library declaration file.
It was in there for historical reasons. Please feel free to remove it.

[Lasse Reichstein Nielsen, 2012-08-29 09:09:39]

I removed 'compiler' from LIBRARIES.
The only difference for dart2js is now that dart:mirror is available.

https://chromiumcodereview.appspot.com/10894005/diff/1/lib/compiler/implement...
File lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10894005/diff/1/lib/compiler/implement...
lib/compiler/implementation/apiimpl.dart:39: String dartLibraryPath(String
dartLibraryName) {
Renamed to lookupDartLibraryPath to make it a verb-phrase.

https://chromiumcodereview.appspot.com/10894005/diff/1/lib/compiler/implement...
lib/compiler/implementation/apiimpl.dart:48: String dartPatchPath(String
dartLibraryName) {
Dittos.

[Lasse Reichstein Nielsen, 2012-08-29 10:18:18]

Peter: Please take another look.

[ahe, 2012-08-29 12:30:21]

Not looking good: private method ;-)

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
File lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
lib/compiler/implementation/apiimpl.dart:36: static bool _hasOption(List<String>
options, String option) {
Why is this method private?

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
lib/compiler/implementation/apiimpl.dart:42: if (info == null) return null;
Please use === as long as the new == semantics aren't implemented in dart2js.

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
lib/compiler/implementation/apiimpl.dart:45: if (path == null) path = info.path;
===

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
lib/compiler/implementation/apiimpl.dart:45: if (path == null) path = info.path;
This looks like a bail out, but it is not a return statement. I think my style
preference would be:

if (path == null) {
  path = info.path;
}

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
lib/compiler/implementation/apiimpl.dart:49: String lookupDartPatchPath(String
dartLibraryName) {
Remove "dart" from method name. This brings focus to the difference.

[Lasse Reichstein Nielsen, 2012-08-29 12:43:53]

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
File lib/compiler/implementation/apiimpl.dart (right):

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
lib/compiler/implementation/apiimpl.dart:36: static bool _hasOption(List<String>
options, String option) {
Because it can't be unnamed, and I can't make it visible only in the scope of
the super-call.
But I'll make it public.
And remove it when Collection gets a "contains" method.

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
lib/compiler/implementation/apiimpl.dart:42: if (info == null) return null;
The semantics change will not make any difference here. 
But done.

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
lib/compiler/implementation/apiimpl.dart:45: if (path == null) path = info.path;
On 2012/08/29 12:30:21, ahe wrote:
> ===

Done.

https://chromiumcodereview.appspot.com/10894005/diff/10001/lib/compiler/imple...
lib/compiler/implementation/apiimpl.dart:49: String lookupDartPatchPath(String
dartLibraryName) {
On 2012/08/29 12:30:21, ahe wrote:
> Remove "dart" from method name. This brings focus to the difference.

Done.

[ahe, 2012-08-29 12:45:43]

LGTM!