Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 10894004: Remove WebSocketServerSocket. (Closed)

Created:
8 years, 3 months ago by Yuta Kitamura
Modified:
8 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove WebSocketServerSocket. This class is not referenced from any code under src/, and is based on the old WebSocket protocol that is not used anymore (hixie-76 / hybi-00 protocol). BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154396

Patch Set 1 #

Patch Set 2 : Remove error code. #

Total comments: 2

Patch Set 3 : Remove LIMIT_VIOLATION as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1558 lines) Patch
M net/base/net_error_list.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M net/net.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
D net/socket/web_socket_server_socket.h View 1 chunk +0 lines, -64 lines 0 comments Download
D net/socket/web_socket_server_socket.cc View 1 chunk +0 lines, -896 lines 0 comments Download
D net/socket/web_socket_server_socket_unittest.cc View 1 chunk +0 lines, -591 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yuta Kitamura
Hi Matt, could you take a look at this? I asked relevant ChromeOS folks about ...
8 years, 3 months ago (2012-08-29 02:38:00 UTC) #1
mmenke
LGTM, with comment addressed. Hmm...Looks like this was never actually used. The CL that fixed ...
8 years, 3 months ago (2012-08-29 15:22:58 UTC) #2
Yuta Kitamura
https://chromiumcodereview.appspot.com/10894004/diff/4001/net/base/net_error_list.h File net/base/net_error_list.h (right): https://chromiumcodereview.appspot.com/10894004/diff/4001/net/base/net_error_list.h#newcode250 net/base/net_error_list.h:250: NET_ERROR(LIMIT_VIOLATION, -144) On 2012/08/29 15:22:59, Matt Menke wrote: > ...
8 years, 3 months ago (2012-08-31 04:05:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yutak@chromium.org/10894004/9001
8 years, 3 months ago (2012-08-31 04:05:26 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-08-31 06:29:52 UTC) #5
Change committed as 154396

Powered by Google App Engine
This is Rietveld 408576698