Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 10893031: Register WebKitWeightWatcher fonts again on mac (Closed)

Created:
8 years, 3 months ago by Nico
Modified:
8 years, 3 months ago
Reviewers:
tkent
CC:
chromium-reviews, darin-cc_chromium.org, Dirk Pranke
Visibility:
Public.

Description

Register WebKitWeightWatcher fonts again on mac They were disabled because they caused issues on 10.5: https://bugs.webkit.org/show_bug.cgi?id=50709 We no longer use 10.5 anywhere, so let's try turning this back on. It should make fast/css/font-weight-1.html pass on mac. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M webkit/support/platform_support_mac.mm View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
8 years, 3 months ago (2012-08-29 18:29:42 UTC) #1
tony
Does this change any test results? I suspect it would . . .
8 years, 3 months ago (2012-08-29 19:11:54 UTC) #2
Nico
On 2012/08/29 19:11:54, tony wrote: > Does this change any test results? I suspect it ...
8 years, 3 months ago (2012-08-29 19:27:07 UTC) #3
tony
On 2012/08/29 19:27:07, Nico wrote: > On 2012/08/29 19:11:54, tony wrote: > > Does this ...
8 years, 3 months ago (2012-08-29 19:28:10 UTC) #4
tony
We can also wait for Kent to verify that it's safe to make this change.
8 years, 3 months ago (2012-08-29 19:28:46 UTC) #5
Nico
I added that to the CL description. I'll wait for tkent to chime in.
8 years, 3 months ago (2012-08-29 19:29:53 UTC) #6
tkent
LGTM. platform_support_mac.mm uses CTFontManagerRegisterFontsForURLs() to register fonts now. It shouldn't have the issue according to ...
8 years, 3 months ago (2012-08-30 01:05:25 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-08-30 01:08:09 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698