ninja windows: Fix special variables not getting emitted when expanded from VS macros

pylib/gyp/generator/ninja.py

Index: pylib/gyp/generator/ninja.py
===================================================================
--- pylib/gyp/generator/ninja.py	(revision 1487)
+++ pylib/gyp/generator/ninja.py	(working copy)
@@ -549,7 +549,7 @@
       is_cygwin = (self.msvs_settings.IsRuleRunUnderCygwin(action)
                    if self.flavor == 'win' else False)
       args = action['action']
-      rule_name = self.WriteNewNinjaRule(name, args, description,
+      rule_name, _ = self.WriteNewNinjaRule(name, args, description,
                                          is_cygwin, env=env)
 
       inputs = [self.GypPathToNinja(i, env) for i in action['inputs']]
@@ -585,7 +585,8 @@
           ('%s ' + generator_default_variables['RULE_INPUT_PATH']) % name)
       is_cygwin = (self.msvs_settings.IsRuleRunUnderCygwin(rule)
                    if self.flavor == 'win' else False)
-      rule_name = self.WriteNewNinjaRule(name, args, description, is_cygwin)
+      rule_name, args = self.WriteNewNinjaRule(
+          name, args, description, is_cygwin)
 
       # TODO: if the command references the outputs directly, we should
       # simplify it to just use $out.
@@ -1168,8 +1169,6 @@
 
     description = re.sub('[^ a-zA-Z0-9_]', '_', description)
 
-    args = args[:]

[scottmg, 2012/08/29 16:35:35]

(assuming this is pointless since it's immediately copied at 1178)

-
     # gyp dictates that commands are run from the base directory.
     # cd into the directory before running, and adjust paths in
     # the arguments to point to the proper locations.
@@ -1203,7 +1202,7 @@
                     rspfile=rspfile, rspfile_content=rspfile_content)
     self.ninja.newline()
 
-    return rule_name
+    return rule_name, args
 
 
 def CalculateVariables(default_variables, params):