Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 10893025: Android WebView: tidy up source/gyp layout. (Closed)

Created:
8 years, 3 months ago by Torne
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android WebView: tidy up source/gyp layout. 1) Rename WebViewMainDelegate to AwMainDelegate for consistency with other classes. 2) Move gyp file to the top level and don't bother having separate gypi files for the subcomponents for now; the file list is very short anyway and is not going to be a significant source of contention between the small number of webview developers at this time, and it's easier to see what's going on if it's all in one place. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -476 lines) Patch
A + android_webview/android_webview.gyp View 4 chunks +15 lines, -16 lines 0 comments Download
D android_webview/aw_browser.gypi View 1 chunk +0 lines, -11 lines 0 comments Download
D android_webview/lib/android_webview.gyp View 1 chunk +0 lines, -302 lines 0 comments Download
A + android_webview/lib/main/aw_main_delegate.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + android_webview/lib/main/aw_main_delegate.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M android_webview/lib/main/webview_entry_point.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D android_webview/lib/main/webview_main_delegate.h View 1 chunk +0 lines, -45 lines 0 comments Download
D android_webview/lib/main/webview_main_delegate.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M build/all_android.gyp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
Hi Joth, as I mentioned on the other review here's a cl to rearrange the ...
8 years, 3 months ago (2012-08-29 11:05:05 UTC) #1
mkosiba (inactive)
lgtm
8 years, 3 months ago (2012-08-29 11:10:45 UTC) #2
joth
lgtm
8 years, 3 months ago (2012-08-29 21:56:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/10893025/1
8 years, 3 months ago (2012-08-29 21:57:12 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-08-30 00:29:58 UTC) #5
Change committed as 154020

Powered by Google App Engine
This is Rietveld 408576698