Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1966)

Unified Diff: dart/tools/gyp/configurations_xcode.gypi

Issue 10892034: Update V8 to 3.12. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments and more clean-up Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tools/gyp/common.gypi ('k') | deps/all.deps/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/gyp/configurations_xcode.gypi
diff --git a/dart/tools/gyp/configurations_xcode.gypi b/dart/tools/gyp/configurations_xcode.gypi
index 1549da945c6509e2b7df4d3d5e961ae1f6228737..bdd99dfd7af4546b13e240bc8ad374a10dd5a482 100644
--- a/dart/tools/gyp/configurations_xcode.gypi
+++ b/dart/tools/gyp/configurations_xcode.gypi
@@ -1,11 +1,17 @@
-# Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+# Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
+# The purpose of this file and others in this directory is to simulate
+# the Chromium build enviroment. This file is included in all GYP
+# files that are used by the Dart project. This includes V8's GYP
+# files.
+
+# READ BEFORE EDITING:
+# Do not add Dart VM specific configuration to this file. Instead,
+# modify runtime/tools/gyp/runtime-configurations.gypi.
+
{
- 'variables': {
- 'dart_debug_optimization_level%': '2',
- },
'target_defaults': {
'configurations': {
'Dart_Base': {
@@ -21,8 +27,6 @@
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', # -fvisibility-inlines-hidden
'GCC_WARN_NON_VIRTUAL_DESTRUCTOR': 'YES', # -Wnon-virtual-dtor
- # TODO(v8-team): Fix V8 build.
- #'GCC_WARN_HIDDEN_VIRTUAL_FUNCTIONS': 'YES', # -Woverloaded-virtual
'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
ricow1 2012/08/30 09:12:22 we should discuss with Ivan which of the rest of t
ahe 2012/08/30 09:24:30 I agree. Also, the same clean up should be done fo
'WARNING_CFLAGS': [
'<@(common_gcc_warning_flags)',
@@ -48,37 +52,6 @@
'PREBINDING': 'NO',
},
},
-
- 'Dart_ia32_Base': {
- 'xcode_settings': {
- 'ARCHS': [ 'i386' ],
- },
- },
-
- 'Dart_x64_Base': {
- 'xcode_settings': {
- 'ARCHS': [ 'x86_64' ],
- },
- },
-
- 'Dart_simarm_Base': {
- 'xcode_settings': {
- 'ARCHS': [ 'i386' ],
- 'GCC_OPTIMIZATION_LEVEL': '3',
- },
- },
-
- 'Dart_Debug': {
- 'xcode_settings': {
- 'GCC_OPTIMIZATION_LEVEL': '<(dart_debug_optimization_level)',
- },
- },
-
- 'Dart_Release': {
- 'xcode_settings': {
- 'GCC_OPTIMIZATION_LEVEL': '3',
- },
- },
},
},
}
« no previous file with comments | « dart/tools/gyp/common.gypi ('k') | deps/all.deps/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698