Force avatar and wallpaper decoding to use robust JPEG.

chrome/common/chrome_utility_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, so no include guard.
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 60 matching lines @@
 
 // Tell the utility process to decode the given image data.
 IPC_MESSAGE_CONTROL1(ChromeUtilityMsg_DecodeImage,
                      std::vector<unsigned char>)  // encoded image contents
 
 // Tell the utility process to decode the given image data, which is base64
 // encoded.
 IPC_MESSAGE_CONTROL1(ChromeUtilityMsg_DecodeImageBase64,
                      std::string)  // base64 encoded image contents
 
+// Tell the utility process to decode the given JPEG image data with standard
+// libjpeg codec.
+IPC_MESSAGE_CONTROL1(ChromeUtilityMsg_DecodeImageWithIJGlibjpeg,

[sky, 2012/08/29 15:21:54]

Why do we need a new message, can't we add an argument to the existing one?

[Jorge Lucangeli Obes, 2012/08/29 17:04:30]

The way I see this functionality, we're providing a new mechanism for more
robust (but slower) strictly-JPEG decoding.

The regular DecodeImage method supports a whole bunch of image formats. Adding a
second argument that would make most of the byte streams in the first argument
"invalid" sounds brittle.

As for the name, though, I would rather have a name that refers to the "what",
i.e. "RobustJPEGDecodeImage", rather than the "how"/implementation details, i.e.
mentioning IJG libjpeg. We might want to change/update how we do robust image
decoding, we should be able to change that in the utility process without
leaving an outdated message name here. The same would apply for an eventual
argument name.

+                     std::vector<unsigned char>)  // encoded image contents
+
 // Tell the utility process to render the given PDF into a metafile.
 IPC_MESSAGE_CONTROL4(ChromeUtilityMsg_RenderPDFPagesToMetafile,
                      base::PlatformFile,       // PDF file
                      FilePath,                 // Location for output metafile
                      printing::PdfRenderSettings,  // PDF render settitngs
                      std::vector<printing::PageRange>)
 
 // Tell the utility process to parse a JSON string into a Value object.
 IPC_MESSAGE_CONTROL1(ChromeUtilityMsg_ParseJSON,
                      std::string /* JSON to parse */)
@@ skipping 75 matching lines @@
 // capabilities and defaults.
 IPC_MESSAGE_CONTROL2(ChromeUtilityHostMsg_GetPrinterCapsAndDefaults_Succeeded,
                      std::string /* printer name */,
                      printing::PrinterCapsAndDefaults)
 #endif
 
 // Reply when the utility process has failed to obtain the printer
 // capabilities and defaults.
 IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_GetPrinterCapsAndDefaults_Failed,
                      std::string /* printer name */)