Force avatar and wallpaper decoding to use robust JPEG.

chrome/browser/chromeos/extensions/wallpaper_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/wallpaper_private_api.h"
 
 #include "ash/desktop_background/desktop_background_controller.h"
 #include "ash/shell.h"
 #include "base/file_util.h"
 #include "base/json/json_writer.h"
@@ skipping 44 matching lines @@
 
 class WallpaperSetWallpaperFunction::WallpaperDecoder
     : public ImageDecoder::Delegate {
  public:
   explicit WallpaperDecoder(
       scoped_refptr<WallpaperSetWallpaperFunction> function)
       : function_(function) {
   }
 
   void Start(const std::string& image_data) {
-    image_decoder_ = new ImageDecoder(this, image_data);
+    image_decoder_ = new ImageDecoder(this, image_data, true);

[Mihai Parparita -not on Chrome, 2012/08/28 23:39:40]

Drive-by nit: boolean parameters like this make code harder to read. A
JpegDecoder enum with DEFAULT_JPEG_DECODER, STANDARD_JPEG_DECODER values would
make this more readable.

[oshima, 2012/08/29 00:02:48]

While I agree with the issue with the boolean, 
DEFAULT_JPEG_DECODER vs STANDARD_JPEG_DECODER is still confusing.
How about SECURE_JPEG_DECODER?

[Emmanuel Saint-loubert-Bié, 2012/08/29 00:52:52]

Yes good idea. I will do that

     image_decoder_->Start();
   }
 
   void Cancel() {
     cancel_flag_.Set();
     function_->SendResponse(false);
   }
 
   virtual void OnImageDecoded(const ImageDecoder* decoder,
                               const SkBitmap& decoded_image) OVERRIDE {
@@ skipping 112 matching lines @@
   chromeos::WallpaperInfo info = {
       file_name_,
       layout_,
       chromeos::User::ONLINE,
       base::Time::Now().LocalMidnight()
   };
   wallpaper_manager->SetUserWallpaperInfo(email_, info, is_persistent);
   wallpaper_decoder_ = NULL;
   SendResponse(true);
 }