Issue 10892017: app_list: Fix crash after uninstalling last app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10892017: app_list: Fix crash after uninstalling last app. (Closed)

Created:
8 years, 3 months ago by xiyuan

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

app_list: Fix crash after uninstalling last app. BUG=145274 TEST=There should be no crash after uninstalling the last app and then selecting an app. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153863

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
M	ui/app_list/app_list.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/app_list/apps_grid_view.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/app_list/apps_grid_view.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	ui/app_list/apps_grid_view_unittest.cc	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

xiyuan

This CL needs to be merged to M22. I'll add test in a separate CL ...

8 years, 3 months ago (2012-08-28 21:41:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10892017/6001

8 years, 3 months ago (2012-08-29 00:38:33 UTC) #6

Change committed as 153863