Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 10892014: Make HWNDMessageHandler subclass WindowImpl. (Closed)

Created:
8 years, 3 months ago by Ben Goodger (Google)
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

The last little bit of cleanup before HWNDMessageHandler becomes the WindowImpl. . Removes the win32 api pass-thrus on NativeWidgetWin . Adds win32 message pre- and post- filtering to HWNDMessageFilterDelegate so various NWW subclasses can customize message handling. . WidgetSizeIsClientSize -> HWNDMessageHandlerDelegate . MessageLoopForUI::Observer -> HWNDMessageHandler . Fullscreen handler takes a HWND instead of a Widget. Derived from: https://chromiumcodereview.appspot.com/10867096/ which is already R=sky@chromium.org http://crbug.com/142962 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153728

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -212 lines) Patch
M chrome/browser/ui/views/external_tab_container_win.h View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 4 chunks +19 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 4 chunks +42 lines, -32 lines 0 comments Download
M chrome/browser/ui/views/native_constrained_window_win.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M ui/views/widget/native_widget_win.h View 7 chunks +8 lines, -66 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 7 chunks +28 lines, -31 lines 0 comments Download
M ui/views/widget/native_widget_win_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M ui/views/win/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/win/fullscreen_handler.h View 2 chunks +4 lines, -6 lines 0 comments Download
M ui/views/win/fullscreen_handler.cc View 5 chunks +17 lines, -26 lines 0 comments Download
M ui/views/win/hwnd_message_handler.h View 4 chunks +9 lines, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 8 chunks +30 lines, -5 lines 0 comments Download
M ui/views/win/hwnd_message_handler_delegate.h View 2 chunks +19 lines, -0 lines 0 comments Download
M ui/views/window/native_frame_view.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ben Goodger (Google)
8 years, 3 months ago (2012-08-28 21:09:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698