Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: chrome/browser/password_manager/password_form_manager.h

Issue 10892011: Fix for no password save when action URL is modified (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_form_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 21 matching lines...) Expand all
32 // form_on_page is the form that may be submitted and could need login data. 32 // form_on_page is the form that may be submitted and could need login data.
33 // ssl_valid represents the security of the page containing observed_form, 33 // ssl_valid represents the security of the page containing observed_form,
34 // used to filter login results from database. 34 // used to filter login results from database.
35 PasswordFormManager(Profile* profile, 35 PasswordFormManager(Profile* profile,
36 PasswordManager* password_manager, 36 PasswordManager* password_manager,
37 content::WebContents* web_contents, 37 content::WebContents* web_contents,
38 const webkit::forms::PasswordForm& observed_form, 38 const webkit::forms::PasswordForm& observed_form,
39 bool ssl_valid); 39 bool ssl_valid);
40 virtual ~PasswordFormManager(); 40 virtual ~PasswordFormManager();
41 41
42 // Compare basic data of observed_form_ with argument. 42 enum ActionMatch {
43 bool DoesManage(const webkit::forms::PasswordForm& form) const; 43 ACTION_MATCH_REQUIRED,
44 ACTION_MATCH_NOT_REQUIRED
45 };
46
47 // Compare basic data of observed_form_ with argument. Only check the action
48 // URL when action match is required.
49 bool DoesManage(const webkit::forms::PasswordForm& form,
50 ActionMatch action_match) const;
44 51
45 // Retrieves potential matching logins from the database. 52 // Retrieves potential matching logins from the database.
46 void FetchMatchingLoginsFromPasswordStore(); 53 void FetchMatchingLoginsFromPasswordStore();
47 54
48 // Simple state-check to verify whether this object as received a callback 55 // Simple state-check to verify whether this object as received a callback
49 // from the PasswordStore and completed its matching phase. Note that the 56 // from the PasswordStore and completed its matching phase. Note that the
50 // callback in question occurs on the same (and only) main thread from which 57 // callback in question occurs on the same (and only) main thread from which
51 // instances of this class are ever used, but it is required since it is 58 // instances of this class are ever used, but it is required since it is
52 // conceivable that a user (or ui test) could attempt to submit a login 59 // conceivable that a user (or ui test) could attempt to submit a login
53 // prompt before the callback has occured, which would InvokeLater a call to 60 // prompt before the callback has occured, which would InvokeLater a call to
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 // These three fields record the "ActionsTaken" by the browser and 261 // These three fields record the "ActionsTaken" by the browser and
255 // the user with this form, and the result. They are combined and 262 // the user with this form, and the result. They are combined and
256 // recorded in UMA when the manager is destroyed. 263 // recorded in UMA when the manager is destroyed.
257 ManagerAction manager_action_; 264 ManagerAction manager_action_;
258 UserAction user_action_; 265 UserAction user_action_;
259 SubmitResult submit_result_; 266 SubmitResult submit_result_;
260 267
261 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager); 268 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
262 }; 269 };
263 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_ 270 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_FORM_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698