Issue 108913006: Fix patching the receiver (global object -> global proxy) after the interceptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108913006: Fix patching the receiver (global object -> global proxy) after the interceptor. (Closed)

Created:
7 years ago by Toon Verwaest

Modified:
7 years ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix patching the receiver (global object -> global proxy) after the interceptor. This is a temporary fix that will be replaced by loading the proxy from the target function. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18286

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years ago (2013-12-17 14:43:17 UTC) #4

Message was sent while issue was closed.

On 2013/12/10 13:11:15, Toon Verwaest wrote:
> Committed patchset #1 manually as r18286.

FYI: This CL is the reason why we currently can't push to trunk, see
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...
(bisected to that). We should either fix this right now or revert it (at least
on Android), it's blocking more than 70 revision... :-/

Expand Messages | Collapse Messages