git_cl.py - Issue 10891039: --bypass-hooks should bypass all checks, including descriptions checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 10891039: --bypass-hooks should bypass all checks, including descriptions checks. (Closed) Base URL: https://git.chromium.org/chromium/tools/depot_tools.git@master

Patch Set: Fix for maruel Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index e250c8e5e4dfcf884891629f46fbf7d217fd0cbd..9715f31604faeb6583a7eb549f81f090ab08505a 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -1254,9 +1254,12 @@ def SendUpstream(parser, args, cmd):

description = cl.GetDescription()

if not description:

- print 'No description set.'

- print 'Visit %s/edit to set it.' % (cl.GetIssueURL())

- return 1

+ if not cl.GetIssue() and options.bypass_hooks:

+ description = CreateDescriptionFromLog([base_branch])

+ else:

+ print 'No description set.'

+ print 'Visit %s/edit to set it.' % (cl.GetIssueURL())

+ return 1

if cl.GetIssue():

description += "\n\nReview URL: %s" % cl.GetIssueURL()

« no previous file with comments | « no previous file | no next file » | no next file with comments »