--bypass-hooks should bypass all checks, including descriptions checks.

--bypass-hooks should bypass all checks, including descriptions checks.

(Adding this after the pretty bad build bustage today.)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153966

[M-A Ruel, 2012-08-29 20:27:09]

https://chromiumcodereview.appspot.com/10891039/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/10891039/diff/1/git_cl.py#newcode1259
git_cl.py:1259: description = "<Committed without description and with
--bypass-hooks>"
What about?
if not cl.GetIssue() and options.bypass_hooks:
  description = CreateDescriptionFromLog([base_branch])

[Elliot Glaysher, 2012-08-29 20:39:16]

https://chromiumcodereview.appspot.com/10891039/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/10891039/diff/1/git_cl.py#newcode1259
git_cl.py:1259: description = "<Committed without description and with
--bypass-hooks>"
On 2012/08/29 20:27:10, Marc-Antoine Ruel wrote:
> What about?
> if not cl.GetIssue() and options.bypass_hooks:
>   description = CreateDescriptionFromLog([base_branch])

Done.

[M-A Ruel, 2012-08-29 20:40:04]

lgtm

[commit-bot: I haz the power, 2012-08-29 20:40:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10891039/4001

[commit-bot: I haz the power, 2012-08-29 20:43:06]

Change committed as 153966