Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10891033: Switch MetroPinTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org, Ben Goodger (Google), jam
Visibility:
Public.

Description

Switch MetroPinTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155420

Patch Set 1 #

Patch Set 2 : small clean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/ui/browser_commands.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/metro_pin_tab_helper.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/metro_pin_tab_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Avi (use Gerrit)
benwells@ - review ben@, jam@ - FYI
8 years, 3 months ago (2012-08-29 18:36:23 UTC) #1
Ben Goodger (Google)
sweet!
8 years, 3 months ago (2012-08-29 19:41:07 UTC) #2
benwells
lgtm!
8 years, 3 months ago (2012-08-30 01:37:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10891033/1
8 years, 3 months ago (2012-08-30 03:53:47 UTC) #4
commit-bot: I haz the power
Presubmit check for 10891033-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-30 03:53:50 UTC) #5
Avi (use Gerrit)
On 2012/08/30 01:37:23, benwells wrote: > lgtm! Congrats, you are the first TabHelper to move ...
8 years, 3 months ago (2012-08-30 03:53:58 UTC) #6
Avi (use Gerrit)
On 2012/08/29 19:41:07, Ben Goodger (Google) wrote: > sweet! Ben, can you OK this as ...
8 years, 3 months ago (2012-08-30 03:55:13 UTC) #7
Ben Goodger (Google)
yes lgtm
8 years, 3 months ago (2012-08-30 18:07:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10891033/1
8 years, 3 months ago (2012-08-30 18:11:34 UTC) #9
commit-bot: I haz the power
Try job failure for 10891033-1 (previous was lost) (previous was lost) (retry) on linux_rel for ...
8 years, 3 months ago (2012-08-30 21:01:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10891033/1
8 years, 3 months ago (2012-09-05 14:16:43 UTC) #11
commit-bot: I haz the power
Try job failure for 10891033-1 (retry) (retry) on mac_rel for steps "nacl_integration, interactive_ui_tests, browser_tests, sync_integration_tests, ...
8 years, 3 months ago (2012-09-05 15:28:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10891033/1
8 years, 3 months ago (2012-09-05 15:42:21 UTC) #13
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 3 months ago (2012-09-05 17:01:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10891033/1
8 years, 3 months ago (2012-09-07 00:55:24 UTC) #15
commit-bot: I haz the power
Try job failure for 10891033-1 (retry) (retry) on mac_rel for steps "nacl_integration, interactive_ui_tests, browser_tests, sync_integration_tests, ...
8 years, 3 months ago (2012-09-07 02:19:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10891033/1
8 years, 3 months ago (2012-09-07 12:51:42 UTC) #17
commit-bot: I haz the power
Try job failure for 10891033-1 (retry) (retry) on mac_rel for steps "nacl_integration, interactive_ui_tests, browser_tests, sync_integration_tests, ...
8 years, 3 months ago (2012-09-07 13:53:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10891033/14008
8 years, 3 months ago (2012-09-07 14:31:42 UTC) #19
commit-bot: I haz the power
8 years, 3 months ago (2012-09-07 17:07:01 UTC) #20
Try job failure for 10891033-14008 (retry) (retry) on mac_rel for step
"sync_integration_tests".
It's a second try, previously, step "sync_integration_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698