Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10891023: add a name: and mark it as required (Closed)

Created:
8 years, 3 months ago by sethladd
Modified:
8 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
jjinux
Base URL:
git@github.com:dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

add a name: and mark it as required BUG=

Patch Set 1 #

Total comments: 8

Patch Set 2 : tweaks from review #

Patch Set 3 : the most simple pubspec has a name #

Patch Set 4 : tweak to instructions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M src/site/docs/pub-package-manager/index.markdown View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
M src/site/docs/pub-package-manager/pubspec.markdown View 1 3 chunks +11 lines, -9 lines 0 comments Download
M src/site/docs/pub-package-manager/versioning.markdown View 1 3 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sethladd
Wanted to make it clear that name: is required. PTAL. Thanks!
8 years, 3 months ago (2012-08-29 08:53:48 UTC) #1
Bob Nystrom
Nits, but LGTM! https://chromiumcodereview.appspot.com/10891023/diff/1/src/site/docs/pub-package-manager/pubspec.markdown File src/site/docs/pub-package-manager/pubspec.markdown (right): https://chromiumcodereview.appspot.com/10891023/diff/1/src/site/docs/pub-package-manager/pubspec.markdown#newcode32 src/site/docs/pub-package-manager/pubspec.markdown:32: **Required**: every package needs a name. ...
8 years, 3 months ago (2012-08-29 17:47:32 UTC) #2
sethladd
Thanks. Made some tweaks. Awesome fact: mere hours after I made this CL, we received ...
8 years, 3 months ago (2012-08-29 19:49:18 UTC) #3
Bob Nystrom
https://chromiumcodereview.appspot.com/10891023/diff/1/src/site/docs/pub-package-manager/pubspec.markdown File src/site/docs/pub-package-manager/pubspec.markdown (right): https://chromiumcodereview.appspot.com/10891023/diff/1/src/site/docs/pub-package-manager/pubspec.markdown#newcode32 src/site/docs/pub-package-manager/pubspec.markdown:32: **Required**: every package needs a name. When your stellar ...
8 years, 3 months ago (2012-08-29 19:53:50 UTC) #4
sethladd
8 years, 3 months ago (2012-08-29 20:01:41 UTC) #5
https://chromiumcodereview.appspot.com/10891023/diff/1/src/site/docs/pub-pack...
File src/site/docs/pub-package-manager/pubspec.markdown (right):

https://chromiumcodereview.appspot.com/10891023/diff/1/src/site/docs/pub-pack...
src/site/docs/pub-package-manager/pubspec.markdown:32: **Required**: every
package needs a name. When your stellar code gets props on the world
I changed it a bit in the latest patch. I think a table would be fine now,
actually, but it's not a big deal.

I can image:

field, required, type (num, strong, bool), format, notes

Also, this is the kind of thing we can do for you after things settle down a
little.

Powered by Google App Engine
This is Rietveld 408576698