Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: content/browser/gpu/gpu_process_host_ui_shim.cc

Issue 10891013: Make GpuDataManager thread safe. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gpu/gpu_process_host_ui_shim.cc
===================================================================
--- content/browser/gpu/gpu_process_host_ui_shim.cc (revision 153783)
+++ content/browser/gpu/gpu_process_host_ui_shim.cc (working copy)
@@ -180,11 +180,9 @@
DCHECK(CalledOnValidThread());
g_hosts_by_id.Pointer()->Remove(host_id_);
- DictionaryValue* dict = new DictionaryValue();
- dict->SetInteger("level", logging::LOG_ERROR);
- dict->SetString("header", "GpuProcessHostUIShim");
- dict->SetString("message", "GPU Process Crashed.");
- GpuDataManagerImpl::GetInstance()->AddLogMessage(dict);
+ GpuDataManagerImpl::GetInstance()->AddLogMessage(
+ logging::LOG_ERROR, "GpuProcessHostUIShim",
+ "GPU Process Crashed.");
}
bool GpuProcessHostUIShim::OnControlMessageReceived(
@@ -223,11 +221,8 @@
int level,
const std::string& header,
const std::string& message) {
- DictionaryValue* dict = new DictionaryValue();
- dict->SetInteger("level", level);
- dict->SetString("header", header);
- dict->SetString("message", message);
- GpuDataManagerImpl::GetInstance()->AddLogMessage(dict);
+ GpuDataManagerImpl::GetInstance()->AddLogMessage(
+ level, header, message);
}
void GpuProcessHostUIShim::OnGraphicsInfoCollected(

Powered by Google App Engine
This is Rietveld 408576698