patch.py - Issue 10890039: Enable support to remove the executable bit on the CQ.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: patch.py

Issue 10890039: Enable support to remove the executable bit on the CQ. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Silence propdel when the property didn't exist Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: patch.py

diff --git a/patch.py b/patch.py

index 90886e9a0fc23ae142e1f524ecee7f18f83d39fe..a41c9e40ef1e9e39407e9ce9de853a3998a98c5f 100644

--- a/patch.py

+++ b/patch.py

@@ -391,9 +391,10 @@ class FilePatchDiff(FilePatchBase):

if match:

mode = match.group(2)

# Only look at owner ACL for executable.

- # TODO(maruel): Add support to remove a property.

if bool(int(mode[4]) & 1):

self.svn_properties.append(('svn:executable', '*'))

+ else:

+ self.svn_properties.append(('svn:executable', None))

return

match = re.match(r'^--- (.*)$', line)

« no previous file with comments | « checkout.py ('k') | no next file » | no next file with comments »