Enable support to remove the executable bit on the CQ.

checkout.py

 # coding=utf8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Manages a project checkout.
 
 Includes support for svn, git-svn and git.
 """
 
 import ConfigParser
@@ skipping 339 matching lines @@
                   cmd, stdin=p.get(False), cwd=self.project_path)
             elif p.is_new and not os.path.exists(filepath):
               # There is only a header. Just create the file if it doesn't
               # exist.
               open(filepath, 'w').close()
           if p.is_new and not p.source_filename:
             # Do not run it if p.source_filename is defined, since svn copy was
             # using above.
             stdout += self._check_output_svn(
                 ['add', p.filename, '--force'], credentials=False)
-          for prop in p.svn_properties:
-            stdout += self._check_output_svn(
-                ['propset', prop[0], prop[1], p.filename], credentials=False)
+          for name, value in p.svn_properties:
+            if value is None:
+              stdout += self._check_output_svn(
+                  ['propdel', '--quiet', name, p.filename], credentials=False)
+            else:
+              stdout += self._check_output_svn(
+                  ['propset', name, value, p.filename], credentials=False)
           for prop, values in self.svn_config.auto_props.iteritems():
             if fnmatch.fnmatch(p.filename, prop):
               for value in values.split(';'):
                 if '=' not in value:
                   params = [value, '*']
                 else:
                   params = value.split('=', 1)
                 stdout += self._check_output_svn(
                     ['propset'] + params + [p.filename], credentials=False)
         for post in post_processors:
@@ skipping 148 matching lines @@
             os.makedirs(full_dir)
           if p.is_binary:
             with open(os.path.join(self.project_path, p.filename), 'wb') as f:
               f.write(p.get())
             stdout += self._check_output_git(['add', p.filename])
           else:
             # No need to do anything special with p.is_new or if not
             # p.diff_hunks. git apply manages all that already.
             stdout += self._check_output_git(
                 ['apply', '--index', '-p%s' % p.patchlevel], stdin=p.get(True))
-          for prop in p.svn_properties:
+          for name, _ in p.svn_properties:
             # Ignore some known auto-props flags through .subversion/config,
             # bails out on the other ones.
             # TODO(maruel): Read ~/.subversion/config and detect the rules that
             # applies here to figure out if the property will be correctly
             # handled.
-            if not prop[0] in (
+            if not name in (
                 'svn:eol-style', 'svn:executable', 'svn:mime-type'):
               raise patch.UnsupportedPatchFormat(
                   p.filename,
                   'Cannot apply svn property %s to file %s.' % (
-                        prop[0], p.filename))
+                        name, p.filename))
         for post in post_processors:
           post(self, p)
       except OSError, e:
         raise PatchApplicationFailed(p, '%s%s' % (stdout, e))
       except subprocess.CalledProcessError, e:
         raise PatchApplicationFailed(
             p, '%s%s' % (stdout, getattr(e, 'stdout', None)))
     # Once all the patches are processed and added to the index, commit the
     # index.
     self._check_call_git(['commit', '-m', 'Committed patch'])
@@ skipping 90 matching lines @@
   def revisions(self, rev1, rev2):
     return self.checkout.revisions(rev1, rev2)
 
   @property
   def project_name(self):
     return self.checkout.project_name
 
   @property
   def project_path(self):
     return self.checkout.project_path