Enable support to remove the executable bit on the CQ.

Enable support to remove the executable bit on the CQ.

R=petermayo@chromium.org
BUG=124817
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153908

[Peter Mayo, 2012-08-29 16:31:47]

LGTM

Seems like this will be included on a lot of files.  Is it worth the overhead of
checking to see if it has been changed on the client side?

[M-A Ruel, 2012-08-29 16:38:05]

On 2012/08/29 16:31:47, Peter Mayo wrote:
> LGTM
> 
> Seems like this will be included on a lot of files.  Is it worth the overhead
of
> checking to see if it has been changed on the client side?

It only happens if there is a line "new file mode" so it's not as bad as it may
seem.

[commit-bot: I haz the power, 2012-08-29 16:38:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10890039/1

[commit-bot: I haz the power, 2012-08-29 16:40:39]

Presubmit check for 10890039-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/checkout_test.py failed!
Command tests/checkout_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools
.....E...EEE...E.EE
======================================================================
ERROR: testAll (__main__.ReadOnlyCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 511, in testAll
    self._check_base(self._get_co(None), root, False, None)
  File "tests/checkout_test.py", line 158, in _check_base
    co.apply_patch(patches)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 640, in
apply_patch
    patches, post_processors or self.post_processors)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 384, in
apply_patch
    ' '.join(e.cmd), stdout, getattr(e, 'stdout', '')))
PatchApplicationFailed: Failed to apply patch for new_dir/subdir/new_file:
While running svn propdel svn:executable new_dir/subdir/new_file
--non-interactive;
A         new_dir
A         new_dir/subdir
patching file new_dir/subdir/new_file
A         new_dir/subdir/new_file
svn: Attempting to delete nonexistent property 'svn:executable'


======================================================================
ERROR: testProcess (__main__.ReadOnlyCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 523, in testProcess
    self._test_process(self._get_co)
  File "tests/checkout_test.py", line 215, in _test_process
    co.apply_patch(ps)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 640, in
apply_patch
    patches, post_processors or self.post_processors)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 384, in
apply_patch
    ' '.join(e.cmd), stdout, getattr(e, 'stdout', '')))
PatchApplicationFailed: Failed to apply patch for new_dir/subdir/new_file:
While running svn propdel svn:executable new_dir/subdir/new_file
--non-interactive;
A         new_dir
A         new_dir/subdir
patching file new_dir/subdir/new_file
A         new_dir/subdir/new_file
svn: Attempting to delete nonexistent property 'svn:executable'


======================================================================
ERROR: testAll (__main__.SvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 305, in testAll
    self._check_base(self._get_co(None), root, False, expected)
  File "tests/checkout_test.py", line 158, in _check_base
    co.apply_patch(patches)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 384, in
apply_patch
    ' '.join(e.cmd), stdout, getattr(e, 'stdout', '')))
PatchApplicationFailed: Failed to apply patch for new_dir/subdir/new_file:
While running svn propdel svn:executable new_dir/subdir/new_file
--non-interactive;
A         new_dir
A         new_dir/subdir
patching file new_dir/subdir/new_file
A         new_dir/subdir/new_file
svn: Attempting to delete nonexistent property 'svn:executable'


======================================================================
ERROR: testAutoProps (__main__.SvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 383, in testAutoProps
    co.apply_patch(patches)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 384, in
apply_patch
    ' '.join(e.cmd), stdout, getattr(e, 'stdout', '')))
PatchApplicationFailed: Failed to apply patch for new_dir/subdir/new_file:
While running svn propdel svn:executable new_dir/subdir/new_file --config-dir
/b/commit-queue/workdir/tools/depot_tools/tests/subversion_config
--non-interactive;
A         new_dir
A         new_dir/subdir
patching file new_dir/subdir/new_file
A         new_dir/subdir/new_file
svn: Attempting to delete nonexistent property 'svn:executable'


======================================================================
ERROR: testProcess (__main__.SvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 394, in testProcess
    self._test_process(self._get_co)
  File "tests/checkout_test.py", line 215, in _test_process
    co.apply_patch(ps)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 384, in
apply_patch
    ' '.join(e.cmd), stdout, getattr(e, 'stdout', '')))
PatchApplicationFailed: Failed to apply patch for new_dir/subdir/new_file:
While running svn propdel svn:executable new_dir/subdir/new_file
--non-interactive;
A         new_dir
A         new_dir/subdir
patching file new_dir/subdir/new_file
A         new_dir/subdir/new_file
svn: Attempting to delete nonexistent property 'svn:executable'


======================================================================
ERROR: testWithRevPropsSupport (__main__.SvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 360, in testWithRevPropsSupport
    self._check_base(self._get_co(None), root, False, expected)
  File "tests/checkout_test.py", line 158, in _check_base
    co.apply_patch(patches)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 384, in
apply_patch
    ' '.join(e.cmd), stdout, getattr(e, 'stdout', '')))
PatchApplicationFailed: Failed to apply patch for new_dir/subdir/new_file:
While running svn propdel svn:executable new_dir/subdir/new_file
--non-interactive;
A         new_dir
A         new_dir/subdir
patching file new_dir/subdir/new_file
A         new_dir/subdir/new_file
svn: Attempting to delete nonexistent property 'svn:executable'


======================================================================
ERROR: testWithRevPropsSupportNotCommitBot (__main__.SvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 375, in
testWithRevPropsSupportNotCommitBot
    self._check_base(co, root, False, expected)
  File "tests/checkout_test.py", line 158, in _check_base
    co.apply_patch(patches)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 384, in
apply_patch
    ' '.join(e.cmd), stdout, getattr(e, 'stdout', '')))
PatchApplicationFailed: Failed to apply patch for new_dir/subdir/new_file:
While running svn propdel svn:executable new_dir/subdir/new_file
--non-interactive;
A         new_dir
A         new_dir/subdir
patching file new_dir/subdir/new_file
A         new_dir/subdir/new_file
svn: Attempting to delete nonexistent property 'svn:executable'


----------------------------------------------------------------------
Ran 19 tests in 3.217s

FAILED (errors=7)


Presubmit checks took 142.2s to calculate.

[commit-bot: I haz the power, 2012-08-29 17:19:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10890039/6001

[commit-bot: I haz the power, 2012-08-29 17:22:24]

Change committed as 153908