android_webview/renderer/DEPS - Issue 10890024: Implement DocuementHasImages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/renderer/DEPS

Issue 10890024: Implement DocuementHasImages (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+third_party/WebKit/Source/WebKit/chromium",
	Torne 2012/08/29 10:34:29 Rather than add a new deps file here, I'd just put Rather than add a new deps file here, I'd just put this rule in the one a level above? joth 2012/08/29 22:28:05 yeah that is how content and chrome do it. I kind Show quoted text On 2012/08/29 10:34:29, Torne wrote: > Rather than add a new deps file here, I'd just put this rule in the one a level > above? yeah that is how content and chrome do it. I kind of liked the idea that we explicitly don't allow webkit code to be called on browser side, especially as we're running single process only at the moment, we might get away with calling some webkit API that would break in multiprocess. mode. (likewise we could have rules in browser/ and render/ to exclude depending on each other. or do we get that automatically?)
	3 ]

OLD	NEW