Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Unified Diff: ui/views/controls/webview/webview.cc

Issue 10890023: Miscellaneous cleanups from several months ago I never got around to landing. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_notification_types.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/webview/webview.cc
===================================================================
--- ui/views/controls/webview/webview.cc (revision 154486)
+++ ui/views/controls/webview/webview.cc (working copy)
@@ -217,9 +217,12 @@
wcv_holder_->Detach();
#if defined(OS_WIN) && !defined(USE_AURA)
// TODO(beng): This should either not be necessary, or be done implicitly by
- // NativeViewHostWin on Detach(). As it stands, this is needed
- // so that the view of the detached contents knows to tell the
- // renderer its been hidden.
+ // NativeViewHostWin on Detach(). As it stands, this is needed so that the
+ // view of the detached contents knows to tell the renderer it's been
+ // hidden.
+ //
+ // Moving this out of here would also mean we wouldn't be potentially
+ // calling member functions on a half-destroyed WebContents.
ShowWindow(web_contents_->GetNativeView(), SW_HIDE);
#endif
}
« no previous file with comments | « chrome/common/chrome_notification_types.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698