Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 10890023: Miscellaneous cleanups from several months ago I never got around to landing. (Closed)

Created:
8 years, 3 months ago by Peter Kasting
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, ncarter (slow), akalin, kkania, tfarina, yoshiki+watch_chromium.org, marja+watch_chromium.org, Satish, robertshield, rdsmith+dwatch_chromium.org, Raghu Simha, tim (not reviewing)
Visibility:
Public.

Description

Miscellaneous cleanups from several months ago I never got around to landing. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154549

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -309 lines) Patch
M chrome/browser/alternate_nav_url_fetcher.cc View 1 2 3 4 2 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 2 3 4 10 chunks +38 lines, -59 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 1 2 3 4 1 chunk +28 lines, -50 lines 0 comments Download
M chrome/browser/printing/background_printing_manager.cc View 1 2 3 4 2 chunks +12 lines, -24 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 2 3 4 2 chunks +25 lines, -42 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 2 3 4 9 chunks +18 lines, -31 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_controller.cc View 1 2 3 4 4 chunks +18 lines, -21 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 3 4 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 2 3 4 7 chunks +19 lines, -34 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 2 3 4 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 2 3 4 1 chunk +7 lines, -8 lines 0 comments Download
M ui/views/controls/webview/webview.cc View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
Makes almost all files shorter! ->sky since he's also OWNER for most of this... https://chromiumcodereview.appspot.com/10890023/diff/10002/chrome/browser/automation/automation_provider_observers.cc ...
8 years, 3 months ago (2012-08-29 01:21:38 UTC) #1
sky
8 years, 3 months ago (2012-08-29 14:46:33 UTC) #2
I love a game of spot the difference. LGTM

Powered by Google App Engine
This is Rietveld 408576698