Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2053)

Unified Diff: chrome/common/child_process_logging_mac.mm

Issue 10890015: [Linux] Add field trial tuples to breakpad crash reports. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/child_process_logging.h ('k') | chrome/common/child_process_logging_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/child_process_logging_mac.mm
===================================================================
--- chrome/common/child_process_logging_mac.mm (revision 153910)
+++ chrome/common/child_process_logging_mac.mm (working copy)
@@ -37,7 +37,7 @@
const char *kGPUGLVersionParamName = "gpu-glver";
const char *kNumberOfViews = "num-views";
NSString* const kNumExtensionsName = @"num-extensions";
-NSString* const kExtensionNameFormat = @"extension-%d";
+NSString* const kExtensionNameFormat = @"extension-%zu";
NSString* const kPrinterInfoNameFormat = @"prn-info-%zu";
// Account for the terminating null character.
@@ -122,7 +122,7 @@
// Record up to |kMaxReportedActiveExtensions| extensions, clearing
// keys if there aren't that many.
std::set<std::string>::const_iterator iter = extension_ids.begin();
- for (int i = 0; i < kMaxReportedActiveExtensions; ++i) {
+ for (size_t i = 0; i < kMaxReportedActiveExtensions; ++i) {
NSString* key = [NSString stringWithFormat:kExtensionNameFormat, i];
if (iter != extension_ids.end()) {
SetCrashKeyValue(key, [NSString stringWithUTF8String:iter->c_str()]);
@@ -163,7 +163,7 @@
}
void SetGpuInfo(const content::GPUInfo& gpu_info) {
- SetGpuInfoImpl(gpu_info, SetCrashKeyValue);
+ SetGpuInfoImpl(gpu_info, SetCrashKeyValue);
}
void SetPrinterInfo(const char* printer_info) {
@@ -188,7 +188,7 @@
}
void SetNumberOfViews(int number_of_views) {
- SetNumberOfViewsImpl(number_of_views, SetCrashKeyValue);
+ SetNumberOfViewsImpl(number_of_views, SetCrashKeyValue);
}
void SetCommandLine(const CommandLine* command_line) {
« no previous file with comments | « chrome/common/child_process_logging.h ('k') | chrome/common/child_process_logging_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698