Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: lib/compiler/implementation/compile_time_constants.dart

Issue 10890007: Remove more warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/elements/elements.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/compile_time_constants.dart
diff --git a/lib/compiler/implementation/compile_time_constants.dart b/lib/compiler/implementation/compile_time_constants.dart
index 80dcdd8e8da7c90c25bc60c3f58db524059adf49..8ac98717717a0c9901ec2dd0c6d72b600d7822c4 100644
--- a/lib/compiler/implementation/compile_time_constants.dart
+++ b/lib/compiler/implementation/compile_time_constants.dart
@@ -53,7 +53,7 @@ class FunctionConstant extends Constant {
}
void _writeJsCode(CodeBuffer buffer, ConstantHandler handler) {
- compiler.internalError(
+ handler.compiler.internalError(
"A constant function does not need specific JS code");
}
@@ -873,7 +873,7 @@ class CompileTimeConstantEvaluator extends AbstractVisitor {
Element element = elements[send];
if (Elements.isStaticOrTopLevelField(element)) {
if (element.modifiers === null ||
- // TODO(johnniwinther): This should eventually be [isConst].
+ // TODO(johnniwinther): This should eventually be [isConst].
!element.modifiers.isFinalOrConst()) {
error(send);
}
« no previous file with comments | « no previous file | lib/compiler/implementation/elements/elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698