Make V8ValueConverter.FromV8Value behave similarly to JSON.stringify

content/public/renderer/v8_value_converter.h

Index: content/public/renderer/v8_value_converter.h
diff --git a/content/public/renderer/v8_value_converter.h b/content/public/renderer/v8_value_converter.h
index be45ea9d3f56325e181ce057cbe10026f2f2e7ca..bb77d7f58837922edd7f275810991d48533a925d 100644
--- a/content/public/renderer/v8_value_converter.h
+++ b/content/public/renderer/v8_value_converter.h
@@ -28,31 +28,46 @@ class CONTENT_EXPORT V8ValueConverter {
 
   virtual ~V8ValueConverter() {}
 
-  // Use the following setters to support additional types other than the
-  // default ones.
-  virtual bool GetUndefinedAllowed() const = 0;
-  virtual void SetUndefinedAllowed(bool val) = 0;
-
-  virtual bool GetDateAllowed() const = 0;
+  // If true, Date objects are converted into DoubleValues with the number of
+  // seconds since Unix epoch.

[koz (OOO until 15th September), 2012/09/14 02:05:44]

Good job on adding comments.

+  //
+  // Otherwise they are converted into DictionaryValues with whatever additional
+  // properties has been set on them.
   virtual void SetDateAllowed(bool val) = 0;
 
-  virtual bool GetRegexpAllowed() const = 0;
-  virtual void SetRegexpAllowed(bool val) = 0;
+  // If true, RegExp objects are converted into StringValues with the regular
+  // expression between / and /, for example "/ab?c/".
+  //
+  // Otherwise they are converted into DictionaryValues with whatever additional
+  // properties has been set on them.
+  virtual void SetRegExpAllowed(bool val) = 0;
+
+  // If true, Function objects are converted into DictionaryValues with whatever
+  // additional properties has been set on them.

[koz (OOO until 15th September), 2012/09/14 02:05:44]

"Otherwise they are omitted from dictionaries and arrays they are a member of."
?

[not at google - send to devlin, 2012/09/15 06:24:24]

Done.

+  virtual void SetFunctionAllowed(bool val) = 0;
 
-  // Gets/sets whether to treat undefined or null in objects as nonexistent.
-  virtual bool GetStripNullFromObjects() const = 0;
+  // If true, null values are stripped from objects. This is often useful when
+  // converting arguments to extension APIs.
   virtual void SetStripNullFromObjects(bool val) = 0;
 
-  // Converts Value to v8::Value. Unsupported types are replaced with null.
-  // If an array or object throws while setting a value, that property or item
-  // is skipped, leaving a hole in the case of arrays.
+  // Converts a base::Value to a v8::Value.
+  //
+  // Unsupported types are replaced with null.  If an array or object throws
+  // while setting a value, that property or item is skipped, leaving a hole in
+  // the case of arrays.
   virtual v8::Handle<v8::Value> ToV8Value(
       const base::Value* value,
       v8::Handle<v8::Context> context) const = 0;
 
-  // Converts v8::Value to Value. Unsupported types are replaced with null.
-  // If an array or object throws while getting a value, that property or item
-  // is replaced with null.
+  // Converts a v8::Value to base::Value.
+  //
+  // Unsupported types (unless explicitly configured) are not converted, so
+  // this method may return NULL -- the exception is when converting arrays,
+  // where unsupported types are converted to Value(TYPE_NULL).
+  //
+  // Likewise, if an object throws while converting a property it will not be
+  // converted, whereas if an array throws while converting an item it will be
+  // converted to Value(TYPE_NULL).
   virtual base::Value* FromV8Value(v8::Handle<v8::Value> value,
                                    v8::Handle<v8::Context> context) const = 0;
 };