chrome/renderer/resources/extensions/storage_custom_bindings.js - Issue 10890002: Make V8ValueConverter.FromV8Value behave similarly to JSON.stringify

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/storage_custom_bindings.js

Issue 10890002: Make V8ValueConverter.FromV8Value behave similarly to JSON.stringify (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use the actual objects, not empty objects Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/storage_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/storage_custom_bindings.js b/chrome/renderer/resources/extensions/storage_custom_bindings.js

index 9b0ece5e5982c8625de72b820b7660ee0a5ba388..d2300991ae0b140abe28a599b226f002bb44f322 100644

--- a/chrome/renderer/resources/extensions/storage_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/storage_custom_bindings.js

@@ -33,7 +33,8 @@ chromeHidden.registerCustomType('storage.StorageArea', function() {

return sendRequest(

'storage.' + functionName,

[namespace].concat(args),

- extendSchema(funSchema.definition.parameters));

+ extendSchema(funSchema.definition.parameters),

+ {preserveNullInObjects: true});

};

}

var apiFunctions = ['get', 'set', 'remove', 'clear', 'getBytesInUse'];