chrome/renderer/extensions/event_bindings.cc - Issue 10890002: Make V8ValueConverter.FromV8Value behave similarly to JSON.stringify

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/event_bindings.cc

Issue 10890002: Make V8ValueConverter.FromV8Value behave similarly to JSON.stringify (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use the actual objects, not empty objects Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/event_bindings.cc

diff --git a/chrome/renderer/extensions/event_bindings.cc b/chrome/renderer/extensions/event_bindings.cc

index 329a70bb8cda4fc3769dda4bcd645841125c3f9e..94258dbeca6d2cab08180df321a0cafa79bd0cdd 100644

--- a/chrome/renderer/extensions/event_bindings.cc

+++ b/chrome/renderer/extensions/event_bindings.cc

@@ -191,6 +191,8 @@ class ExtensionImpl : public ChromeV8Extension {

base::DictionaryValue* filter_dict = NULL;

base::Value* filter_value = converter->FromV8Value(args[1]->ToObject(),

v8::Context::GetCurrent());

+ if (!filter_value)

+ return v8::Integer::New(-1);

if (!filter_value->GetAsDictionary(&filter_dict)) {

delete filter_value;

return v8::Integer::New(-1);