chrome/renderer/resources/extensions/context_menus_custom_bindings.js - Issue 10890002: Make V8ValueConverter.FromV8Value behave similarly to JSON.stringify

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/context_menus_custom_bindings.js

Issue 10890002: Make V8ValueConverter.FromV8Value behave similarly to JSON.stringify (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: no more function Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/user_script_scheduler.cc ('k') | chrome/renderer/resources/extensions/schema_generated_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/context_menus_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/context_menus_custom_bindings.js b/chrome/renderer/resources/extensions/context_menus_custom_bindings.js

index 9e4016a468b138375d96b4205388cd21bd739f7d..e2629f7b49594812755e17b582065c3a6183dbbb 100644

--- a/chrome/renderer/resources/extensions/context_menus_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/context_menus_custom_bindings.js

@@ -48,10 +48,10 @@ chromeHidden.registerCustomHook('contextMenus', function(bindingsAPI) {

var args = arguments;

var id = GetNextContextMenuId();

args[0].generatedId = id;

- sendRequest(this.name,

- args,

- this.definition.parameters,

- {customCallback: this.customCallback});

+ var optArgs = {

+ customCallback: this.customCallback,

+ };

+ sendRequest(this.name, args, this.definition.parameters, optArgs);

return chromeHidden.contextMenus.getIdFromCreateProperties(args[0]);

});